sneak/pixa
1
0
Fork 0
Code Issues 5 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

style: use the config key error-message convention for signing_key
All checks were successful
check / check (push) Successful in 1m48s
Details

Browse Source 
The signing_key errors used bare phrasing while every other validation
error follows the 'config key %q' convention; align them. The secret
value itself is still never echoed.
This commit is contained in:
Jeffrey Paul
2026-08-07 17:04:08 +00:00
parent 83fa22871e
commit 22f19c849b
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
internal/config/config.go
View File

@@ -262,15 +262,16 @@ func (c *Config) ensureStateDirWritable() error {
// validate checks that all required configuration values are set and // validate checks that all required configuration values are set and
// that every value is within its valid range. // that every value is within its valid range.
func (c *Config) validate() error { func (c *Config) validate() error {
// The signing key value is never echoed in error messages.
if c.SigningKey == "" { if c.SigningKey == "" {
return fmt.Errorf("signing_key is required") return fmt.Errorf("config key %q: a value is required", "signing_key")
} }
// Minimum key length for security (32 bytes = 256 bits) // Minimum key length for security (32 bytes = 256 bits)
const minKeyLength = 32 const minKeyLength = 32
if len(c.SigningKey) < minKeyLength { if len(c.SigningKey) < minKeyLength {
return fmt.Errorf("signing_key must be at least %d characters, got %d", return fmt.Errorf("config key %q: value must be at least %d characters, got %d",
minKeyLength, len(c.SigningKey)) "signing_key", minKeyLength, len(c.SigningKey))
} }
const maxPort = 65535 const maxPort = 65535