The new package internal/imagerequest holds the request type, its two parts Source and Transform, the Format and Fit types, the dimension and fit checks, the /v1/image/ path parsing and the variant key; it imports no other package of pixa. imgcache.ParsedURL, imgcache.ImageRequest, signature.Request, imageprocessor.Request, the second Size, format and fit types and the conversions between them are gone. The image processor takes a Transform only. encurl keeps a private struct with the token's short CBOR field names. VariantKey moves with the function that makes it. Tests follow the moved and renamed code; the tests of the removed conversions go with them. Model: opus-5-5
This commit was merged in pull request #323.
This commit is contained in:
@@ -30,6 +30,17 @@ P2: security: per-origin rate limiting
|
||||
|
||||
# Completed Steps
|
||||
|
||||
- 2026-10-21 one image request type instead of five (closes #307): the new
|
||||
package `internal/imagerequest`, which imports no other package of pixa, holds
|
||||
`imagerequest.Request` with its two parts, `Source` (host, path and query) and
|
||||
`Transform` (size, format, quality and fit), the `Format` and `Fit` types, the
|
||||
checks, the parsing of the `/v1/image/` path and the variant key.
|
||||
`imgcache.ParsedURL`, `imgcache.ImageRequest`, `signature.Request`,
|
||||
`imageprocessor.Request`, the second `Size`, format and fit types and the
|
||||
conversions between them are gone. The image processor takes a `Transform`
|
||||
only, and `encurl` keeps a private struct with the token's short CBOR field
|
||||
names, so tokens made before still decode. Every URL of both image routes
|
||||
answers as before.
|
||||
- 2026-10-21 the Gitea workflow checks out the repo and runs `script/cibuild`,
|
||||
nothing else (closes #203): its `script/docker-smoke` step is removed, as the
|
||||
canonical `REPO_POLICIES.md` says, since `make check` covers what CI needs to
|
||||
|
||||
Reference in New Issue
Block a user