Add the # to RPL_ENDOFWHO for an unknown channel over HTTP (closes #249) #252

Merged
clawbot merged 1 commits from issue-249-who-unknown-channel-endofwho into next 2026-11-03 08:38:45 +01:00
Collaborator

WHO over the HTTP API adds a missing # to to, but the unknown-channel path sent RPL_ENDOFWHO (315) with the name as sent. It now sends the name with the #, as the found-channel path does. So {"command":"WHO","to":"nosuch"} with no such channel gets params ["#nosuch"], matching README.md.

TestWhoUnknownChannelEndReplyAddsHash covers this case.

The IRC port has its own WHO handler, which this change does not touch.

Closes #249

Model: opus-5-5

`WHO` over the HTTP API adds a missing `#` to `to`, but the unknown-channel path sent `RPL_ENDOFWHO` (`315`) with the name as sent. It now sends the name with the `#`, as the found-channel path does. So `{"command":"WHO","to":"nosuch"}` with no such channel gets `params` `["#nosuch"]`, matching `README.md`. `TestWhoUnknownChannelEndReplyAddsHash` covers this case. The IRC port has its own `WHO` handler, which this change does not touch. Closes https://git.eeqj.de/sneak/neoirc/issues/249 Model: opus-5-5
clawbot added the needs-review label 2026-11-03 08:08:05 +01:00
clawbot self-assigned this 2026-11-03 08:08:06 +01:00
clawbot added 1 commit 2026-11-03 08:08:06 +01:00
WHO over the HTTP API adds a missing # to the channel name, but the
unknown-channel path sent RPL_ENDOFWHO with the name as sent. A client
keyed on the channel name saw two spellings. Both paths now send the
name with the #.

Model: opus-5-5
Author
Collaborator

The unknown-channel 315 in #252 now carries the name with the #, and its test covers what #249 asks for, so this passes review.

Model: opus-5-5

The unknown-channel `315` in https://git.eeqj.de/sneak/neoirc/pulls/252 now carries the name with the `#`, and its test covers what https://git.eeqj.de/sneak/neoirc/issues/249 asks for, so this passes review. Model: opus-5-5
clawbot merged commit 4221f71920 into next 2026-11-03 08:38:45 +01:00
clawbot deleted branch issue-249-who-unknown-channel-endofwho 2026-11-03 08:38:46 +01:00
Sign in to join this conversation.