WHO over the HTTP API: RPL_ENDOFWHO for an unknown channel carries the name as sent, not with the # added #249

New Issue

2026-11-03T07:52:05+01:00

clawbot commented

2026-11-03 07:52:05 +01:00

handleWho in internal/handlers/api.go adds a missing # to to, but on the unknown-channel path it enqueues RPL_ENDOFWHO (315) with params [target], the name as sent. The found-channel path uses [channel], the name with the #.

Example over the HTTP API: {"command":"WHO","to":"nosuch"} with no such channel queues 315 with params ["nosuch"]. The same request against an existing #nosuch ends with 315 params ["#nosuch"]. README.md says WHO adds a missing # and that 315 carries [channel]; a client keyed on the channel name gets two spellings.

Definition of done:

The unknown-channel 315 carries the #-normalised name, the same as the found-channel one.
A handler test sends WHO with a to that lacks the # for a channel that does not exist and asserts params is ["#nosuch"].
make check is green. README.md needs no change.

Found during the fresh read of README.md for #190.

Model: fable-5-1

`handleWho` in `internal/handlers/api.go` adds a missing `#` to `to`, but on the unknown-channel path it enqueues `RPL_ENDOFWHO` (`315`) with `params` `[target]`, the name as sent. The found-channel path uses `[channel]`, the name with the `#`. Example over the HTTP API: `{"command":"WHO","to":"nosuch"}` with no such channel queues `315` with `params` `["nosuch"]`. The same request against an existing `#nosuch` ends with `315` `params` `["#nosuch"]`. `README.md` says `WHO` adds a missing `#` and that `315` carries `[channel]`; a client keyed on the channel name gets two spellings. Definition of done: - The unknown-channel `315` carries the `#`-normalised name, the same as the found-channel one. - A handler test sends `WHO` with a `to` that lacks the `#` for a channel that does not exist and asserts `params` is `["#nosuch"]`. - `make check` is green. `README.md` needs no change. Found during the fresh read of `README.md` for https://git.eeqj.de/sneak/neoirc/issues/190. Model: fable-5-1

clawbot referenced this issue

2026-11-03 07:54:45 +01:00

Fix the sentences a fresh read of README.md failed (closes #190) #251

clawbot referenced this issue from a commit

2026-11-03 08:07:52 +01:00

Add the # to RPL_ENDOFWHO for an unknown channel over HTTP (closes #249)

clawbot referenced a pull request that will close this issue

2026-11-03 08:08:06 +01:00

Add the # to RPL_ENDOFWHO for an unknown channel over HTTP (closes #249) #252

clawbot commented

2026-11-03 08:08:12 +01:00