A fresh read of README.md on next, sentence by sentence against the rules on the issue and against the code. One sentence failed; it is fixed in place. Nothing else is changed.
Broken, under The IRC listener, Commands:
"PASS after registration answers a password of the wrong length with a NOTICE, not ERR_NEEDMOREPARAMS (461), and a stored password with a NOTICE too." It takes a second reading to see that "a stored password" means the case where the password is accepted. Now two sentences: the NOTICE on success first, then the NOTICE instead of 461 on a wrong length. Both match handlePassPostReg and checkPasswordLength in internal/ircserver.
Nothing false found: every other statement was checked against the code on next and holds.
Two places where the code, not the document, looks wrong are filed and the text stands: #249 (WHO on an unknown channel echoes the name as sent in 315) and #250 (MAX_MESSAGE_SIZE bounds only the first JSON value read).
Not checked: the server was not run; browser and curl cookie behaviour on localhost.
Model: fable-5-1
Part of https://git.eeqj.de/sneak/neoirc/issues/190.
A fresh read of `README.md` on `next`, sentence by sentence against the rules on the issue and against the code. One sentence failed; it is fixed in place. Nothing else is changed.
Broken, under The IRC listener, Commands:
- "`PASS` after registration answers a password of the wrong length with a `NOTICE`, not `ERR_NEEDMOREPARAMS` (`461`), and a stored password with a `NOTICE` too." It takes a second reading to see that "a stored password" means the case where the password is accepted. Now two sentences: the `NOTICE` on success first, then the `NOTICE` instead of `461` on a wrong length. Both match `handlePassPostReg` and `checkPasswordLength` in `internal/ircserver`.
Nothing false found: every other statement was checked against the code on `next` and holds.
Two places where the code, not the document, looks wrong are filed and the text stands: https://git.eeqj.de/sneak/neoirc/issues/249 (`WHO` on an unknown channel echoes the name as sent in `315`) and https://git.eeqj.de/sneak/neoirc/issues/250 (`MAX_MESSAGE_SIZE` bounds only the first JSON value read).
Not checked: the server was not run; browser and `curl` cookie behaviour on `localhost`.
Model: fable-5-1
A fresh read of README.md on next, sentence by sentence against
the rules on #190 and the
code, failed one sentence. The IRC listener bullet on PASS after
registration ("answers a password of the wrong length with a
NOTICE, not ERR_NEEDMOREPARAMS (461), and a stored password with a
NOTICE too") needs a second reading to see that "a stored password"
means the case where the password is accepted. It is now two short
sentences: the NOTICE on success first, then the NOTICE instead of
461 on a wrong length. Both facts match handlePassPostReg and
checkPasswordLength in internal/ircserver. Every other sentence
passed; nothing else is changed.
Model: fable-5-1
clawbot
changed title from Fix the sentences a fresh read of README.md failed to Fix the sentences a fresh read of README.md failed (closes #190)2026-11-03 08:00:51 +01:00
PASS: both sentences of the changed PASS bullet are true of handlePassPostReg and checkPasswordLength and meet the rules on #190, and nothing else changes.
Model: opus-5-5
PASS: both sentences of the changed `PASS` bullet are true of `handlePassPostReg` and `checkPasswordLength` and meet the rules on https://git.eeqj.de/sneak/neoirc/issues/190, and nothing else changes.
Model: opus-5-5
clawbot
merged commit 254873a656 into next2026-11-03 08:20:55 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Part of #190.
A fresh read of
README.mdonnext, sentence by sentence against the rules on the issue and against the code. One sentence failed; it is fixed in place. Nothing else is changed.Broken, under The IRC listener, Commands:
PASSafter registration answers a password of the wrong length with aNOTICE, notERR_NEEDMOREPARAMS(461), and a stored password with aNOTICEtoo." It takes a second reading to see that "a stored password" means the case where the password is accepted. Now two sentences: theNOTICEon success first, then theNOTICEinstead of461on a wrong length. Both matchhandlePassPostRegandcheckPasswordLengthininternal/ircserver.Nothing false found: every other statement was checked against the code on
nextand holds.Two places where the code, not the document, looks wrong are filed and the text stands: #249 (
WHOon an unknown channel echoes the name as sent in315) and #250 (MAX_MESSAGE_SIZEbounds only the first JSON value read).Not checked: the server was not run; browser and
curlcookie behaviour onlocalhost.Model: fable-5-1
Fix the sentences a fresh read of README.md failedto Fix the sentences a fresh read of README.md failed (closes #190)PASS: both sentences of the changed
PASSbullet are true ofhandlePassPostRegandcheckPasswordLengthand meet the rules on #190, and nothing else changes.Model: opus-5-5