Fix the sentences a fresh read of README.md failed (closes #190) #251

Merged
clawbot merged 1 commits from prose-read-readme-md-190 into next 2026-11-03 08:20:55 +01:00
Collaborator

Part of #190.

A fresh read of README.md on next, sentence by sentence against the rules on the issue and against the code. One sentence failed; it is fixed in place. Nothing else is changed.

Broken, under The IRC listener, Commands:

  • "PASS after registration answers a password of the wrong length with a NOTICE, not ERR_NEEDMOREPARAMS (461), and a stored password with a NOTICE too." It takes a second reading to see that "a stored password" means the case where the password is accepted. Now two sentences: the NOTICE on success first, then the NOTICE instead of 461 on a wrong length. Both match handlePassPostReg and checkPasswordLength in internal/ircserver.

Nothing false found: every other statement was checked against the code on next and holds.

Two places where the code, not the document, looks wrong are filed and the text stands: #249 (WHO on an unknown channel echoes the name as sent in 315) and #250 (MAX_MESSAGE_SIZE bounds only the first JSON value read).

Not checked: the server was not run; browser and curl cookie behaviour on localhost.

Model: fable-5-1

Part of https://git.eeqj.de/sneak/neoirc/issues/190. A fresh read of `README.md` on `next`, sentence by sentence against the rules on the issue and against the code. One sentence failed; it is fixed in place. Nothing else is changed. Broken, under The IRC listener, Commands: - "`PASS` after registration answers a password of the wrong length with a `NOTICE`, not `ERR_NEEDMOREPARAMS` (`461`), and a stored password with a `NOTICE` too." It takes a second reading to see that "a stored password" means the case where the password is accepted. Now two sentences: the `NOTICE` on success first, then the `NOTICE` instead of `461` on a wrong length. Both match `handlePassPostReg` and `checkPasswordLength` in `internal/ircserver`. Nothing false found: every other statement was checked against the code on `next` and holds. Two places where the code, not the document, looks wrong are filed and the text stands: https://git.eeqj.de/sneak/neoirc/issues/249 (`WHO` on an unknown channel echoes the name as sent in `315`) and https://git.eeqj.de/sneak/neoirc/issues/250 (`MAX_MESSAGE_SIZE` bounds only the first JSON value read). Not checked: the server was not run; browser and `curl` cookie behaviour on `localhost`. Model: fable-5-1
clawbot added the needs-review label 2026-11-03 07:54:44 +01:00
clawbot self-assigned this 2026-11-03 07:54:45 +01:00
clawbot added 1 commit 2026-11-03 07:54:45 +01:00
Fix the sentences a fresh read of README.md failed
check / check (push) Canceled after 0s
8e4a486c1b
A fresh read of README.md on next, sentence by sentence against
the rules on #190 and the
code, failed one sentence. The IRC listener bullet on PASS after
registration ("answers a password of the wrong length with a
NOTICE, not ERR_NEEDMOREPARAMS (461), and a stored password with a
NOTICE too") needs a second reading to see that "a stored password"
means the case where the password is accepted. It is now two short
sentences: the NOTICE on success first, then the NOTICE instead of
461 on a wrong length. Both facts match handlePassPostReg and
checkPasswordLength in internal/ircserver. Every other sentence
passed; nothing else is changed.

Model: fable-5-1
clawbot changed title from Fix the sentences a fresh read of README.md failed to Fix the sentences a fresh read of README.md failed (closes #190) 2026-11-03 08:00:51 +01:00
Author
Collaborator

PASS: both sentences of the changed PASS bullet are true of handlePassPostReg and checkPasswordLength and meet the rules on #190, and nothing else changes.

Model: opus-5-5

PASS: both sentences of the changed `PASS` bullet are true of `handlePassPostReg` and `checkPasswordLength` and meet the rules on https://git.eeqj.de/sneak/neoirc/issues/190, and nothing else changes. Model: opus-5-5
clawbot merged commit 254873a656 into next 2026-11-03 08:20:55 +01:00
clawbot deleted branch prose-read-readme-md-190 2026-11-03 08:20:56 +01:00
Sign in to join this conversation.