Make the PASS notice name the HTTP API login (closes #217) #241

Merged
clawbot merged 1 commits from issue-217-pass-notice into next 2026-11-02 05:27:28 +01:00
Collaborator

After PASS on the IRC listener, the NOTICE that confirms it told the user to reconnect with PASS and their nick. The IRC listener cannot add a connection to an existing session, so that step does not work. The notice now reads:

Password set. Another client can log in to this session over the HTTP API: POST /api/v1/login with your nick and this password.

This is what README.md says in Multi-Client Model and in the PASS section: POST /api/v1/login is the only way to add a client to an existing session.

TestHandlePassPostRegistration in internal/ircserver now checks the whole notice text, not just its first two words.

What a reader might trip over: a PASS sent before registration gets no confirming notice at all, so that path is unchanged.

Disclosures:

  • Judgement call: the notice does not say that closing the IRC connection ends the session, along with any client logged in to it over the HTTP API. The issue asked for only the two facts above.

Model: opus-5-5

After `PASS` on the IRC listener, the `NOTICE` that confirms it told the user to reconnect with `PASS` and their nick. The IRC listener cannot add a connection to an existing session, so that step does not work. The notice now reads: `Password set. Another client can log in to this session over the HTTP API: POST /api/v1/login with your nick and this password.` This is what `README.md` says in Multi-Client Model and in the `PASS` section: `POST /api/v1/login` is the only way to add a client to an existing session. `TestHandlePassPostRegistration` in `internal/ircserver` now checks the whole notice text, not just its first two words. What a reader might trip over: a `PASS` sent before registration gets no confirming notice at all, so that path is unchanged. Disclosures: - Judgement call: the notice does not say that closing the IRC connection ends the session, along with any client logged in to it over the HTTP API. The issue asked for only the two facts above. Model: opus-5-5
clawbot added the needs-review label 2026-11-02 05:12:44 +01:00
clawbot self-assigned this 2026-11-02 05:12:44 +01:00
clawbot added 1 commit 2026-11-02 05:12:44 +01:00
After PASS on the IRC listener, the confirming NOTICE told the user to
reconnect with PASS and their nick. The IRC listener cannot add a
connection to an existing session, so that step does not work. The
notice now says the password is set and that another client can log in
to the session over the HTTP API with POST /api/v1/login, as the README
describes. The test now checks the whole notice text.

Model: opus-5-5
Author
Collaborator

PASS: after PASS on the IRC listener, the confirming NOTICE now points to POST /api/v1/login with the nick and this password, which works, instead of a reconnect over IRC, which does not.

Judgement call: the notice does not say that closing the IRC connection ends the session for every client logged in to it; I do not count that as misleading, because the notice claims nothing about how long the session lasts and README.md says so.

Model: opus-5-5

PASS: after `PASS` on the IRC listener, the confirming `NOTICE` now points to `POST /api/v1/login` with the nick and this password, which works, instead of a reconnect over IRC, which does not. Judgement call: the notice does not say that closing the IRC connection ends the session for every client logged in to it; I do not count that as misleading, because the notice claims nothing about how long the session lasts and `README.md` says so. Model: opus-5-5
clawbot merged commit acb9527944 into next 2026-11-02 05:27:28 +01:00
clawbot deleted branch issue-217-pass-notice 2026-11-02 05:27:28 +01:00
Sign in to join this conversation.