The IRC listener's PASS notice promises a reconnect the server does not support #217

Closed
opened 2026-10-27 14:21:59 +01:00 by clawbot · 1 comment
Collaborator

On the IRC listener, a successful PASS after registration sets the session's password and answers with the NOTICE "Password set. You can reconnect using PASS <password> with your nick." (internal/ircserver/commands.go). The listener cannot log a new connection into an existing session that way, so the notice promises something the server does not do. Found by the rewrite of the README for #190; read from the code on ecf47c3.

Fix: the notice says only what is true: that the password is set, and, if the server has one, the real way to use it to reach the same session from another client (read README.md Multi-Client Model and the login code to find it). If there is no such way on the IRC listener, say where there is one. Change nothing else.

Definition of done

  1. The NOTICE after PASS names no step the server does not support, and its text matches README.md.
  2. A test in internal/ircserver checks the notice text.
  3. One reviewed PR against next.

Model: opus-5-5

On the IRC listener, a successful `PASS` after registration sets the session's password and answers with the `NOTICE` "Password set. You can reconnect using PASS &lt;password&gt; with your nick." (`internal/ircserver/commands.go`). The listener cannot log a new connection into an existing session that way, so the notice promises something the server does not do. Found by the rewrite of the README for https://git.eeqj.de/sneak/neoirc/issues/190; read from the code on `ecf47c3`. Fix: the notice says only what is true: that the password is set, and, if the server has one, the real way to use it to reach the same session from another client (read `README.md` Multi-Client Model and the login code to find it). If there is no such way on the IRC listener, say where there is one. Change nothing else. ## Definition of done 1. The `NOTICE` after `PASS` names no step the server does not support, and its text matches `README.md`. 2. A test in `internal/ircserver` checks the notice text. 3. One reviewed PR against `next`. Model: opus-5-5
Author
Collaborator

The notice after PASS on the IRC listener no longer tells the user to reconnect with PASS. It now says the password is set and that another client can log in to the session over the HTTP API with POST /api/v1/login, as the README describes. A test in internal/ircserver checks the whole text. PR: #241

Model: opus-5-5

The notice after `PASS` on the IRC listener no longer tells the user to reconnect with `PASS`. It now says the password is set and that another client can log in to the session over the HTTP API with `POST /api/v1/login`, as the README describes. A test in `internal/ircserver` checks the whole text. PR: https://git.eeqj.de/sneak/neoirc/pulls/241 Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/neoirc#217