sneak/mfer
1
0
Fork 0
Code Issues 21 Pull Requests 2 Actions 42 Releases Wiki Activity

golangci-lint warns that gomodguard is deprecated in favour of gomodguard_v2 #116

New Issue
Open
opened 2026-10-03 16:08:41 +02:00 by clawbot · 2 comments
clawbot commented 2026-10-03 16:08:41 +02:00
Collaborator
Copy Link
Copy Source

Problem

Every lint run on next prints: The linter 'gomodguard' is deprecated (since v2.12.0) due to: new major version. Replaced by gomodguard_v2. .golangci.yml enables every linter (default: all), so both the old and the new one run. The same file already disables wsl for the same reason (replaced by wsl_v5).

Definition of done

  • gomodguard is added to the disable list in .golangci.yml with the same style of comment as wsl; gomodguard_v2 stays enabled.
  • The lint step no longer prints the deprecation warning.
  • make check passes; TODO.md updated in the same commit.
  • If the canonical .golangci.yml in sneak/prompts has the same gap, say so in one line in the PR body; do not change that repo from here.
  • Commit title ends with (closes #N) for this issue's number.

Model: opus-5-5

## Problem Every lint run on `next` prints: `The linter 'gomodguard' is deprecated (since v2.12.0) due to: new major version. Replaced by gomodguard_v2.` `.golangci.yml` enables every linter (`default: all`), so both the old and the new one run. The same file already disables `wsl` for the same reason (replaced by `wsl_v5`). ## Definition of done - `gomodguard` is added to the `disable` list in `.golangci.yml` with the same style of comment as `wsl`; `gomodguard_v2` stays enabled. - The lint step no longer prints the deprecation warning. - `make check` passes; `TODO.md` updated in the same commit. - If the canonical `.golangci.yml` in `sneak/prompts` has the same gap, say so in one line in the PR body; do not change that repo from here. - Commit title ends with ` (closes #N)` for this issue's number. Model: opus-5-5
clawbot commented 2026-10-04 10:16:11 +02:00
Author
Collaborator
Copy Link
Copy Source

gomodguard is now in the disable list of .golangci.yml, next to wsl; gomodguard_v2 stays enabled and reports nothing. PR: #135

Model: opus-5-5

`gomodguard` is now in the `disable` list of `.golangci.yml`, next to `wsl`; `gomodguard_v2` stays enabled and reports nothing. PR: https://git.eeqj.de/sneak/mfer/pulls/135 Model: opus-5-5
clawbot commented 2026-10-04 11:02:51 +02:00
Author
Collaborator
Copy Link
Copy Source

Corrected scope: .golangci.yml is vendored and must not be hand-edited, so this is fixed by mfer's part of the shared re-vendor, sneak/prompts#78: fetch every canonical file verbatim from sneak/prompts main, bring Dockerfile, Makefile and script/ in line, fix any new findings in the code, and lint with zero deprecation warnings. Per that issue it starts once sneak/prompts#65 (the newer lint pin) reaches main there, which waits on sneak/prompts#68. The hand edit in #135 is closed unmerged.

Model: opus-5-5

Corrected scope: `.golangci.yml` is vendored and must not be hand-edited, so this is fixed by mfer's part of the shared re-vendor, https://git.eeqj.de/sneak/prompts/issues/78: fetch every canonical file verbatim from `sneak/prompts` `main`, bring `Dockerfile`, `Makefile` and `script/` in line, fix any new findings in the code, and lint with zero deprecation warnings. Per that issue it starts once https://git.eeqj.de/sneak/prompts/issues/65 (the newer lint pin) reaches `main` there, which waits on https://git.eeqj.de/sneak/prompts/pulls/68. The hand edit in https://git.eeqj.de/sneak/mfer/pulls/135 is closed unmerged. Model: opus-5-5
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/mfer#116