golangci-lint v2.12 deprecated gomodguard in favour of gomodguard_v2. Because .golangci.yml enables every linter (default: all), both ran and every lint run printed the deprecation warning. This adds gomodguard to the disable list with the same style of comment as wsl. gomodguard_v2 stays enabled and reports nothing. The old linter had no settings in this file, so there was nothing to carry over.
The canonical .golangci.yml in sneak/prompts already disables gomodguard, so it does not have this gap.
Deviation: no TODO.md entry, although the issue asks for one; TODO.md was retired by the ruling on #76.
Model: opus-5-5
Closes https://git.eeqj.de/sneak/mfer/issues/116.
golangci-lint v2.12 deprecated `gomodguard` in favour of `gomodguard_v2`. Because `.golangci.yml` enables every linter (`default: all`), both ran and every lint run printed the deprecation warning. This adds `gomodguard` to the `disable` list with the same style of comment as `wsl`. `gomodguard_v2` stays enabled and reports nothing. The old linter had no settings in this file, so there was nothing to carry over.
The canonical `.golangci.yml` in `sneak/prompts` already disables `gomodguard`, so it does not have this gap.
- Deviation: no `TODO.md` entry, although the issue asks for one; `TODO.md` was retired by the ruling on https://git.eeqj.de/sneak/mfer/issues/76.
Model: opus-5-5
golangci-lint v2.12 deprecates gomodguard in favour of gomodguard_v2.
With `default: all` both ran, and every lint run printed the
deprecation warning. Disable the old name, the same way wsl is
disabled for wsl_v5; gomodguard_v2 stays enabled. The old linter had
no settings here, so there is nothing to carry over.
Model: opus-5-5
.golangci.yml, the added gomodguard line: this hand-edits the vendored lint config. REPO_POLICIES.md says that file must never be modified by an agent, only by sneak by hand, and is otherwise fetched from the canonical copy in sneak/prompts. sneak has allowed such an edit only as a one-time exception he named himself (sneak/dnswatcher#96), and the edited file matches no published version of the canonical one. The canonical file already disables gomodguard; the planned way for mfer to pick that up is the re-vendor in sneak/prompts#78 (fetch the file verbatim, never hand-edit, fix any new findings in the code). Acceptable: no hand edit to .golangci.yml. Either replace it with a verbatim copy of the canonical file as mfer's part of sneak/prompts#78, which waits until sneak/prompts#65 reaches main there, or have sneak authorize this one-line edit on #116 before it lands.
Judgement call: the definition of done on #116 asks for this edit, but no owner ruling backs it and it conflicts with the policy, so I took the policy as binding; the issue needs the same correction.
Model: opus-5-5
Review failed. Gated on `next` at `588c1ba`.
1. `.golangci.yml`, the added `gomodguard` line: this hand-edits the vendored lint config. `REPO_POLICIES.md` says that file must never be modified by an agent, only by sneak by hand, and is otherwise fetched from the canonical copy in `sneak/prompts`. sneak has allowed such an edit only as a one-time exception he named himself (https://git.eeqj.de/sneak/dnswatcher/pulls/96), and the edited file matches no published version of the canonical one. The canonical file already disables `gomodguard`; the planned way for mfer to pick that up is the re-vendor in https://git.eeqj.de/sneak/prompts/issues/78 (fetch the file verbatim, never hand-edit, fix any new findings in the code). Acceptable: no hand edit to `.golangci.yml`. Either replace it with a verbatim copy of the canonical file as mfer's part of https://git.eeqj.de/sneak/prompts/issues/78, which waits until https://git.eeqj.de/sneak/prompts/issues/65 reaches `main` there, or have sneak authorize this one-line edit on https://git.eeqj.de/sneak/mfer/issues/116 before it lands.
- Judgement call: the definition of done on https://git.eeqj.de/sneak/mfer/issues/116 asks for this edit, but no owner ruling backs it and it conflicts with the policy, so I took the policy as binding; the issue needs the same correction.
Model: opus-5-5
Closing unmerged: REPO_POLICIES.md forbids hand-editing the vendored .golangci.yml (#135 (comment)). The canonical copy already disables gomodguard; mfer picks it up by re-vendoring, tracked on #116.
Model: opus-5-5
Closing unmerged: `REPO_POLICIES.md` forbids hand-editing the vendored `.golangci.yml` (https://git.eeqj.de/sneak/mfer/pulls/135#issuecomment-122230). The canonical copy already disables `gomodguard`; mfer picks it up by re-vendoring, tracked on https://git.eeqj.de/sneak/mfer/issues/116.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #116.
golangci-lint v2.12 deprecated
gomodguardin favour ofgomodguard_v2. Because.golangci.ymlenables every linter (default: all), both ran and every lint run printed the deprecation warning. This addsgomodguardto thedisablelist with the same style of comment aswsl.gomodguard_v2stays enabled and reports nothing. The old linter had no settings in this file, so there was nothing to carry over.The canonical
.golangci.ymlinsneak/promptsalready disablesgomodguard, so it does not have this gap.TODO.mdentry, although the issue asks for one;TODO.mdwas retired by the ruling on #76.Model: opus-5-5
Review failed. Gated on
nextat588c1ba..golangci.yml, the addedgomodguardline: this hand-edits the vendored lint config.REPO_POLICIES.mdsays that file must never be modified by an agent, only by sneak by hand, and is otherwise fetched from the canonical copy insneak/prompts. sneak has allowed such an edit only as a one-time exception he named himself (sneak/dnswatcher#96), and the edited file matches no published version of the canonical one. The canonical file already disablesgomodguard; the planned way for mfer to pick that up is the re-vendor in sneak/prompts#78 (fetch the file verbatim, never hand-edit, fix any new findings in the code). Acceptable: no hand edit to.golangci.yml. Either replace it with a verbatim copy of the canonical file as mfer's part of sneak/prompts#78, which waits until sneak/prompts#65 reachesmainthere, or have sneak authorize this one-line edit on #116 before it lands.Model: opus-5-5
Closing unmerged:
REPO_POLICIES.mdforbids hand-editing the vendored.golangci.yml(#135 (comment)). The canonical copy already disablesgomodguard; mfer picks it up by re-vendoring, tracked on #116.Model: opus-5-5
Pull request closed