Format Markdown with prettier in make fmt and fmt-check (closes #23) #25

Merged
clawbot merged 1 commits from prettier-markdown into next 2026-10-06 11:43:52 +02:00
Collaborator

Fixes #23.

make fmt now runs prettier over the Markdown files after the Go formatters, and make fmt-check fails when prettier would change one. package.json, yarn.lock, .prettierrc and .prettierignore are the sneak/prompts copies at dd4027b, unchanged except for package.json as listed below. REPO_POLICIES.md already passes prettier, so .prettierignore needed no entry for it.

Most of the README.md and TODO.md diff is the one-time reformat by make fmt. The wording changes are the formatting line under Contributing and the new Completed Steps entry.

make fmt and make fmt-check now need yarn and prettier on the host. make bootstrap installs them, and script/cibuild runs it first.

Deviations from the model files:

  • package.json has "private": true in place of the model's "license": "MIT", which describes the sneak/prompts licence, not this repository's (sneak/prompts#76).
  • script/bootstrap compares versions where the model tests presence, as the issue asks. A yarn that script/fmt would run is kept if it is 1.22.22. Otherwise yarn is installed through corepack under node 22.17.0: the node on PATH if it has that version, else one installed through nvm.
  • run_yarn in script/fmt and script/fmt-check returns after yarn instead of execing it, because the Go steps share those scripts.

Judgement calls:

  • A yarn on PATH at the pinned version runs under whatever node is on PATH, so the node pin applies only when bootstrap has to install yarn.
  • nvm itself is still found by presence. It only installs the pinned node, and unpacking it over a developer's own nvm would overwrite their copy.

Model: opus-5-5

Fixes https://git.eeqj.de/sneak/attrsum/issues/23. `make fmt` now runs prettier over the Markdown files after the Go formatters, and `make fmt-check` fails when prettier would change one. `package.json`, `yarn.lock`, `.prettierrc` and `.prettierignore` are the `sneak/prompts` copies at `dd4027b`, unchanged except for `package.json` as listed below. `REPO_POLICIES.md` already passes prettier, so `.prettierignore` needed no entry for it. Most of the `README.md` and `TODO.md` diff is the one-time reformat by `make fmt`. The wording changes are the formatting line under Contributing and the new Completed Steps entry. `make fmt` and `make fmt-check` now need yarn and prettier on the host. `make bootstrap` installs them, and `script/cibuild` runs it first. Deviations from the model files: - `package.json` has `"private": true` in place of the model's `"license": "MIT"`, which describes the `sneak/prompts` licence, not this repository's (https://git.eeqj.de/sneak/prompts/issues/76). - `script/bootstrap` compares versions where the model tests presence, as the issue asks. A yarn that `script/fmt` would run is kept if it is 1.22.22. Otherwise yarn is installed through corepack under node 22.17.0: the node on `PATH` if it has that version, else one installed through nvm. - `run_yarn` in `script/fmt` and `script/fmt-check` returns after yarn instead of `exec`ing it, because the Go steps share those scripts. Judgement calls: - A yarn on `PATH` at the pinned version runs under whatever node is on `PATH`, so the node pin applies only when bootstrap has to install yarn. - nvm itself is still found by presence. It only installs the pinned node, and unpacking it over a developer's own nvm would overwrite their copy. Model: opus-5-5
clawbot added the needs-review label 2026-10-06 10:52:02 +02:00
clawbot self-assigned this 2026-10-06 10:52:02 +02:00
Author
Collaborator

Review passed.

Model: opus-5-5

Review passed. Model: opus-5-5
Author
Collaborator

Rework plan. The review passed, but package.json declares "license": "MIT", copied from sneak/prompts, where that field describes the prompts repo's own LICENSE (sneak/prompts#76). attrsum is WTFPL v2 (README.md), and agents do not add or change a licence here, so a licence claim must not land on next. Fix: drop the license field and mark the package "private": true. That makes no licence claim at all, and yarn prints no "No license field" warning for a private package. The PR body lists it as one deviation from the model file. The canonical file's problem goes to sneak/prompts separately.

Model: opus-5-5

Rework plan. The review passed, but `package.json` declares `"license": "MIT"`, copied from `sneak/prompts`, where that field describes the prompts repo's own `LICENSE` (https://git.eeqj.de/sneak/prompts/issues/76). attrsum is WTFPL v2 (`README.md`), and agents do not add or change a licence here, so a licence claim must not land on `next`. Fix: drop the `license` field and mark the package `"private": true`. That makes no licence claim at all, and yarn prints no "No license field" warning for a private package. The PR body lists it as one deviation from the model file. The canonical file's problem goes to `sneak/prompts` separately. Model: opus-5-5
clawbot added needs-rework and removed needs-review labels 2026-10-06 11:10:40 +02:00
clawbot added 1 commit 2026-10-06 11:16:40 +02:00
`make fmt` now runs prettier over the Markdown files after the Go
formatters, and `make fmt-check` fails when prettier would change one.
`package.json`, `yarn.lock`, `.prettierrc` and `.prettierignore` are the
`sneak/prompts` copies at `dd4027b`, except for `"private": true` in
`package.json` in place of the licence field. Both scripts find yarn the
way that repo's scripts do. `script/bootstrap` installs prettier with
`yarn install --frozen-lockfile`. When the yarn those scripts would run
is not 1.22.22, it installs yarn through corepack under node 22.17.0:
the node on `PATH` if it has that version, otherwise one installed
through nvm from a hash-checked archive. `README.md` and `TODO.md` are
reformatted once.

Model: opus-5-5
clawbot force-pushed prettier-markdown from 9af51bd68a to b0b195ffd1 2026-10-06 11:16:40 +02:00 Compare
Author
Collaborator

Rework per #25 (comment): package.json drops "license": "MIT" and is marked "private": true, so it makes no licence claim; the commit message and PR body list it as the one deviation from the model file.

Model: opus-5-5

Rework per https://git.eeqj.de/sneak/attrsum/pulls/25#issuecomment-129152: `package.json` drops `"license": "MIT"` and is marked `"private": true`, so it makes no licence claim; the commit message and PR body list it as the one deviation from the model file. Model: opus-5-5
clawbot added needs-review and removed needs-rework labels 2026-10-06 11:17:04 +02:00
Author
Collaborator

Review passed.

Model: opus-5-5

Review passed. Model: opus-5-5
clawbot merged commit 8976a64832 into next 2026-10-06 11:43:52 +02:00
clawbot deleted branch prettier-markdown 2026-10-06 11:43:53 +02:00
Sign in to join this conversation.