sneak/AutistMask
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: standardize error display to use showError/hideError helpers #90

Closed
clawbot wants to merge 1 commits from fix/87-consistent-error-display into main
pull from: fix/87-consistent-error-display
merge into: sneak:main
Conversation 1 Commits 1 Files Changed 6 +55 -46
clawbot commented 2026-02-28 22:07:01 +01:00
Collaborator
Copy Link

Replace three inconsistent error display patterns with the centralized showError()/hideError() helpers from helpers.js.

Changes:

  • approval.js: replace direct DOM classList toggling with showError/hideError
  • addressDetail.js: replace export-privkey-flash direct DOM with showError/hideError (element renamed to export-privkey-error)
  • deleteWallet.js: replace delete-wallet-flash direct DOM with showError/hideError (element renamed to delete-wallet-error, removed inconsistent text-red-500)
  • addWallet.js: replace showFlash() validation errors with dedicated add-wallet-error div
  • importKey.js: replace showFlash() validation errors with dedicated import-key-error div
  • index.html: add error divs for add-wallet and import-key views, rename flash elements to error elements

docker build . passes.

Closes #87

Replace three inconsistent error display patterns with the centralized `showError()`/`hideError()` helpers from `helpers.js`. **Changes:** - `approval.js`: replace direct DOM classList toggling with `showError`/`hideError` - `addressDetail.js`: replace `export-privkey-flash` direct DOM with `showError`/`hideError` (element renamed to `export-privkey-error`) - `deleteWallet.js`: replace `delete-wallet-flash` direct DOM with `showError`/`hideError` (element renamed to `delete-wallet-error`, removed inconsistent `text-red-500`) - `addWallet.js`: replace `showFlash()` validation errors with dedicated `add-wallet-error` div - `importKey.js`: replace `showFlash()` validation errors with dedicated `import-key-error` div - `index.html`: add error divs for add-wallet and import-key views, rename flash elements to error elements `docker build .` passes. Closes #87
clawbot added the
bot
 label 2026-02-28 22:07:01 +01:00
clawbot added 1 commit 2026-02-28 22:07:01 +01:00
fix: standardize error display to use showError/hideError helpers
All checks were successful
check / check (push) Successful in 9s
Details
5e4cf34ef8 
Replace three inconsistent error display patterns with the centralized
showError()/hideError() helpers from helpers.js:

- approval.js: replace direct DOM classList toggling for approve-tx-error
  and approve-sign-error with showError/hideError calls
- addressDetail.js: replace export-privkey-flash direct DOM with
  showError/hideError using renamed export-privkey-error element
- deleteWallet.js: replace delete-wallet-flash direct DOM with
  showError/hideError using renamed delete-wallet-error element
- addWallet.js: replace showFlash() validation errors with dedicated
  add-wallet-error div and showError/hideError calls
- importKey.js: replace showFlash() validation errors with dedicated
  import-key-error div and showError/hideError calls
- index.html: add error divs for add-wallet and import-key views,
  rename export-privkey-flash to export-privkey-error,
  rename delete-wallet-flash to delete-wallet-error,
  remove inconsistent text-red-500 class

Closes #87
clawbot closed this pull request 2026-02-28 22:07:10 +01:00
clawbot commented 2026-02-28 22:07:11 +01:00
Author
Collaborator
Copy Link

Closing as duplicate of #88.

Closing as duplicate of #88.
All checks were successful
check / check (push) Successful in 9s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bot

Agent's turn to work

  
merge-ready

   
needs-checks

   
needs-rebase

   
needs-review

   
needs-rework
No Label
bot
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sneak/AutistMask#90
No description provided.
Delete Branch "fix/87-consistent-error-display"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?