fix: standardize error display to use showError/hideError helpers #88

clawbot · 2026-02-28T21:49:53+01:00

clawbot commented

2026-02-28 21:49:53 +01:00

Replaces four inconsistent error display patterns with the centralized showError()/hideError() helpers from helpers.js:

approval.js: replace direct classList toggling on approve-tx-error and approve-sign-error
addressDetail.js: rename export-privkey-flash → export-privkey-error, use helpers
deleteWallet.js: rename delete-wallet-flash → delete-wallet-error, use helpers (removes text-red-500)
addWallet.js: replace showFlash() validation errors with dedicated add-wallet-error div (status messages like "Scanning..." still use showFlash)
importKey.js: replace showFlash() validation errors with dedicated import-key-error div
index.html: add/update error divs with min-h-[1.25rem] to prevent layout shift

docker build . passes.

Closes #87

Replaces four inconsistent error display patterns with the centralized `showError()`/`hideError()` helpers from `helpers.js`: - **approval.js**: replace direct `classList` toggling on `approve-tx-error` and `approve-sign-error` - **addressDetail.js**: rename `export-privkey-flash` → `export-privkey-error`, use helpers - **deleteWallet.js**: rename `delete-wallet-flash` → `delete-wallet-error`, use helpers (removes `text-red-500`) - **addWallet.js**: replace `showFlash()` validation errors with dedicated `add-wallet-error` div (status messages like "Scanning..." still use `showFlash`) - **importKey.js**: replace `showFlash()` validation errors with dedicated `import-key-error` div - **index.html**: add/update error divs with `min-h-[1.25rem]` to prevent layout shift `docker build .` passes. Closes #87

clawbot added the bot label 2026-02-28 21:49:53 +01:00

clawbot added 1 commit 2026-02-28 21:49:53 +01:00

fix: standardize error display to use showError/hideError helpers

check / check (push) Successful in 21s

Details

efc299d542

Replaces four inconsistent error display patterns with the centralized
showError()/hideError() helpers from helpers.js:

- approval.js: replace direct classList toggling on approve-tx-error and
  approve-sign-error with showError()/hideError()
- addressDetail.js: rename export-privkey-flash to export-privkey-error,
  use showError()/hideError() instead of direct DOM manipulation
- deleteWallet.js: rename delete-wallet-flash to delete-wallet-error,
  use showError()/hideError() instead of direct DOM with text-red-500
- addWallet.js: replace showFlash() validation errors with dedicated
  add-wallet-error div and showError() (keep showFlash for status msgs)
- importKey.js: replace showFlash() validation errors with dedicated
  import-key-error div and showError()
- index.html: add error divs with min-h-[1.25rem] for add-wallet,
  import-key views; update existing error divs to use consistent
  min-h-[1.25rem] class instead of hidden class

Closes #87

clawbot referenced this pull request

2026-02-28 22:07:11 +01:00

fix: standardize error display to use showError/hideError helpers #90

clawbot closed this pull request

2026-02-28 22:22:27 +01:00

clawbot commented

2026-02-28 22:22:28 +01:00

Closing — issue #87 is addressed by PR #92 (error div consistency) which is merge-ready.