fix: standardize error display to use showError/hideError helpers #90
Closed
clawbot
wants to merge 1 commits from
fix/87-consistent-error-display into main
pull from: fix/87-consistent-error-display
merge into: sneak:main
sneak:main
sneak:issue-259-e2e-in-ci
sneak:issue-275-site-approval-race
sneak:issue-188-dod-assertions
sneak:issue-152-eslint
sneak:next
sneak:issue-271-concurrent-nonce
sneak:issue-280-handlerpc-catch
sneak:fix/issue-153-browser-api-compat
sneak:chore/token-list-enrichment
sneak:feat/issue-131-transaction-view-layout
sneak:fix/116-timestamps-include-timezone
sneak:feature/expanded-warnings
sneak:fix/cross-wallet-duplicate-detection
sneak:feature/copy-flash-feedback
sneak:feature/issue-82-new-address-warning
sneak:feature/82-warn-new-address
sneak:issue-99-block-number-external-link
sneak:issue-99-block-number-styling
sneak:feature/82-zero-history-warning
sneak:fix/issue-99-block-number-link-copy
sneak:fix/99-block-number-clickable
sneak:fix/87-consistent-error-display-v2
sneak:fix/consistent-error-display
sneak:fix/77-confirm-tx-persist
sneak:fix/issue-72-address-token-tx-history
sneak:fix/70-confirm-tx-contract-display
sneak:fix/issue-58-receive-address-consistency
sneak:fix/59-transaction-view-ui-policies
sneak:fix/55-swap-show-own-address
sneak:feature/show-private-key
sneak:feat/message-signing
1 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
| 5e4cf34ef8 |
fix: standardize error display to use showError/hideError helpers
All checks were successful
check / check (push) Successful in 9s
Replace three inconsistent error display patterns with the centralized showError()/hideError() helpers from helpers.js: - approval.js: replace direct DOM classList toggling for approve-tx-error and approve-sign-error with showError/hideError calls - addressDetail.js: replace export-privkey-flash direct DOM with showError/hideError using renamed export-privkey-error element - deleteWallet.js: replace delete-wallet-flash direct DOM with showError/hideError using renamed delete-wallet-error element - addWallet.js: replace showFlash() validation errors with dedicated add-wallet-error div and showError/hideError calls - importKey.js: replace showFlash() validation errors with dedicated import-key-error div and showError/hideError calls - index.html: add error divs for add-wallet and import-key views, rename export-privkey-flash to export-privkey-error, rename delete-wallet-flash to delete-wallet-error, remove inconsistent text-red-500 class Closes #87 |