TxApproval and TransactionDetail had lines with no wrap class. A long symbol, amount or description ran past the right edge and was cut off with no sign of it. These lines now have break-words:
TxApproval: the action, the description, the token symbol on the Contract and decoded lines, the decoded values, and the Value line.
TransactionDetail: the Amount line, the native quantity, and the action, description, token symbol and values of its decoded details.
SuccessTx hid its Amount and To lines whenever it had a decoded action. A saved record with only some lines readable then showed neither. Each line is now hidden only when a readable decoded line shows the same thing: an Amount line, or a line with the address in to.
A swap with no Amount line now shows an Amount line on SuccessTx. It reads Unknown (could not be decoded), or the ETH the swap pays, as on WaitTx and ErrorTx. tests/swapStatusAmount.test.js asserted the opposite, so that test changed. The README's SuccessTx list changed to match.
Disclosures:
Judgement call: the issue names only TransactionDetail's value line. Its native quantity and decoded lines can hold the same long symbol, so they wrap too.
Judgement call: TxApproval's fee lines do not wrap. The issue does not name them, and they carry no token symbol.
Unverified: the wrapping was checked by class name only, not in a browser.
Model: opus-5-5
For https://git.eeqj.de/sneak/AutistMask/issues/743.
TxApproval and TransactionDetail had lines with no wrap class. A long symbol, amount or description ran past the right edge and was cut off with no sign of it. These lines now have `break-words`:
- TxApproval: the action, the description, the token symbol on the Contract and decoded lines, the decoded values, and the Value line.
- TransactionDetail: the Amount line, the native quantity, and the action, description, token symbol and values of its decoded details.
SuccessTx hid its Amount and To lines whenever it had a decoded action. A saved record with only some lines readable then showed neither. Each line is now hidden only when a readable decoded line shows the same thing: an `Amount` line, or a line with the address in `to`.
A swap with no `Amount` line now shows an Amount line on SuccessTx. It reads `Unknown (could not be decoded)`, or the ETH the swap pays, as on WaitTx and ErrorTx. `tests/swapStatusAmount.test.js` asserted the opposite, so that test changed. The README's SuccessTx list changed to match.
Disclosures:
- Judgement call: the issue names only TransactionDetail's value line. Its native quantity and decoded lines can hold the same long symbol, so they wrap too.
- Judgement call: TxApproval's fee lines do not wrap. The issue does not name them, and they carry no token symbol.
- Unverified: the wrapping was checked by class name only, not in a browser.
Model: opus-5-5
TxApproval and TransactionDetail cut off a long symbol, amount or description at
the edge of the screen. These lines now wrap.
SuccessTx hid its Amount and To lines whenever it had a decoded action, even one
that showed neither. Each line is now hidden only when a readable decoded line
shows the same thing. A swap with no Amount line now shows its amount on
SuccessTx, as WaitTx and ErrorTx do.
Model: opus-5-5
Follow-up: renderSuccess() in src/popup/views/txStatus.js hides the Amount line for a saved Amount line whose value is empty text, so the screen then shows no amount, though no code writes such a line; acceptable is to hide it only when line.value is not empty, with a row for it in the table in tests/txStatus.test.js.
Follow-up: the comment at src/popup/views/approval.js line 322 names only the wait and error screens, and SuccessTx now says the same for a swap with no Amount line; acceptable is "The wait, success and error screens say".
Unverified: wrapping was measured in Chromium only, not Firefox.
Model: opus-5-5
PASS: https://git.eeqj.de/sneak/AutistMask/pulls/744 meets the definition of done in https://git.eeqj.de/sneak/AutistMask/issues/743.
Follow-up: `renderSuccess()` in `src/popup/views/txStatus.js` hides the Amount line for a saved `Amount` line whose value is empty text, so the screen then shows no amount, though no code writes such a line; acceptable is to hide it only when `line.value` is not empty, with a row for it in the table in `tests/txStatus.test.js`.
Follow-up: the comment at `src/popup/views/approval.js` line 322 names only the wait and error screens, and SuccessTx now says the same for a swap with no `Amount` line; acceptable is "The wait, success and error screens say".
Unverified: wrapping was measured in Chromium only, not Firefox.
Model: opus-5-5
clawbot
merged commit 64ec571a17 into next2026-11-03 12:27:21 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
For #743.
TxApproval and TransactionDetail had lines with no wrap class. A long symbol, amount or description ran past the right edge and was cut off with no sign of it. These lines now have
break-words:SuccessTx hid its Amount and To lines whenever it had a decoded action. A saved record with only some lines readable then showed neither. Each line is now hidden only when a readable decoded line shows the same thing: an
Amountline, or a line with the address into.A swap with no
Amountline now shows an Amount line on SuccessTx. It readsUnknown (could not be decoded), or the ETH the swap pays, as on WaitTx and ErrorTx.tests/swapStatusAmount.test.jsasserted the opposite, so that test changed. The README's SuccessTx list changed to match.Disclosures:
Model: opus-5-5
PASS: #744 meets the definition of done in #743.
Follow-up:
renderSuccess()insrc/popup/views/txStatus.jshides the Amount line for a savedAmountline whose value is empty text, so the screen then shows no amount, though no code writes such a line; acceptable is to hide it only whenline.valueis not empty, with a row for it in the table intests/txStatus.test.js.Follow-up: the comment at
src/popup/views/approval.jsline 322 names only the wait and error screens, and SuccessTx now says the same for a swap with noAmountline; acceptable is "The wait, success and error screens say".Unverified: wrapping was measured in Chromium only, not Firefox.
Model: opus-5-5