src/popup/views/approval.js and approve-tx-action in src/popup/index.html; the value line in src/popup/views/transactionDetail.js; renderSuccess() in src/popup/views/txStatus.js.
TxApproval's description, token symbol and value lines, and TransactionDetail's value line, have no wrap class. Nothing limits the length of a symbol the explorer reports, so a long one runs past the popup's right edge and is cut off with no sign of it. TxApproval matters most, because the user reads it before signing.
renderSuccess(): the comment "the Amount and To are already shown inside the decoded well" is false for a record with only some lines readable. That screen then shows neither the amount nor the recipient.
What should happen
No amount, symbol or description is cut off with no sign of it. SuccessTx always shows the amount and recipient.
Severity: minor
Definition of done
break-words on each of those elements, with a test on TxApproval.
SuccessTx shows the amount and recipient when the decoded record does not, and the comment is true. A Jest test, failing on next.
Model: opus-5-5
## Where
`src/popup/views/approval.js` and `approve-tx-action` in `src/popup/index.html`; the value line in `src/popup/views/transactionDetail.js`; `renderSuccess()` in `src/popup/views/txStatus.js`.
## What happens
Found by the review of https://git.eeqj.de/sneak/AutistMask/pulls/742.
- TxApproval's description, token symbol and value lines, and TransactionDetail's value line, have no wrap class. Nothing limits the length of a symbol the explorer reports, so a long one runs past the popup's right edge and is cut off with no sign of it. TxApproval matters most, because the user reads it before signing.
- `renderSuccess()`: the comment "the Amount and To are already shown inside the decoded well" is false for a record with only some lines readable. That screen then shows neither the amount nor the recipient.
## What should happen
No amount, symbol or description is cut off with no sign of it. SuccessTx always shows the amount and recipient.
Severity: minor
## Definition of done
- [ ] `break-words` on each of those elements, with a test on TxApproval.
- [ ] SuccessTx shows the amount and recipient when the decoded record does not, and the comment is true. A Jest test, failing on `next`.
Model: opus-5-5
clawbot
self-assigned this 2026-11-03 11:02:43 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Where
src/popup/views/approval.jsandapprove-tx-actioninsrc/popup/index.html; the value line insrc/popup/views/transactionDetail.js;renderSuccess()insrc/popup/views/txStatus.js.What happens
Found by the review of #742.
renderSuccess(): the comment "the Amount and To are already shown inside the decoded well" is false for a record with only some lines readable. That screen then shows neither the amount nor the recipient.What should happen
No amount, symbol or description is cut off with no sign of it. SuccessTx always shows the amount and recipient.
Severity: minor
Definition of done
break-wordson each of those elements, with a test on TxApproval.next.Model: opus-5-5