When two addresses' explorer reports disagree on a token's decimals, the Send screen showed the stored figure (Current balance: 5.0000 NOVEL) while the confirmation screen it leads to said unknown (NOVEL). A new function in src/popup/views/send.js, tokenBalanceAndDecimals(), now gives both the Send screen's balance line and the Review handler the balance and scale, so both screens read unknown (NOVEL), the wording the confirmation screen already used. The handler's comments moved into it.
The fee-unknown message names its cause. With no scale, estimateGas() cannot encode the transfer, so the message says the wallet does not know how many decimal places the token uses and that the transaction cannot be sent, with no retry. Any other cause keeps the old sentence.
Not visible in the diff:
The message text moved out of index.html into show() in confirmTx.js, because it now depends on the pending transaction. It is set before the first paint, so nothing moves.
Against next, the new test fails on the Send line, which reads Current balance: 5.0000 NOVEL.
Disclosures:
Judgement call: the balance list and the token's own screen still show the row's figure for this holding, since they format each row at fetch time without the cross-address check. The README now says so.
Judgement call: the fee message says "this wallet does not know" rather than reusing "nothing this wallet can consult reports", which is untrue when the reports exist but disagree.
Model: opus-5-5
Fixes https://git.eeqj.de/sneak/AutistMask/issues/377.
When two addresses' explorer reports disagree on a token's `decimals`, the Send screen showed the stored figure (`Current balance: 5.0000 NOVEL`) while the confirmation screen it leads to said `unknown (NOVEL)`. A new function in `src/popup/views/send.js`, `tokenBalanceAndDecimals()`, now gives both the Send screen's balance line and the Review handler the balance and scale, so both screens read `unknown (NOVEL)`, the wording the confirmation screen already used. The handler's comments moved into it.
The fee-unknown message names its cause. With no scale, `estimateGas()` cannot encode the transfer, so the message says the wallet does not know how many decimal places the token uses and that the transaction cannot be sent, with no retry. Any other cause keeps the old sentence.
Not visible in the diff:
- The message text moved out of `index.html` into `show()` in `confirmTx.js`, because it now depends on the pending transaction. It is set before the first paint, so nothing moves.
- Against `next`, the new test fails on the Send line, which reads `Current balance: 5.0000 NOVEL`.
Disclosures:
- Judgement call: the balance list and the token's own screen still show the row's figure for this holding, since they format each row at fetch time without the cross-address check. The README now says so.
- Judgement call: the fee message says "this wallet does not know" rather than reusing "nothing this wallet can consult reports", which is untrue when the reports exist but disagree.
Model: opus-5-5
The branch conflicts with next in TODO.md. next added three entries at the top of Completed Steps (#283, #426, #297) in the place where this PR adds its entry (line 48 on the rebased tree). Acceptable: rebase onto the current next and keep every entry.
Not run: the browser e2e suites.
Model: opus-5-5
FAIL
1. The branch conflicts with `next` in `TODO.md`. `next` added three entries at the top of Completed Steps (https://git.eeqj.de/sneak/AutistMask/issues/283, https://git.eeqj.de/sneak/AutistMask/issues/426, https://git.eeqj.de/sneak/AutistMask/issues/297) in the place where this PR adds its entry (line 48 on the rebased tree). Acceptable: rebase onto the current `next` and keep every entry.
Not run: the browser e2e suites.
Model: opus-5-5
When two addresses' explorer reports disagree on a token's decimals, the
Send screen showed the stored figure while the confirmation screen said
the balance was unknown. One function in send.js now gives both the
balance and scale, so both read `unknown (SYMBOL)`.
The confirmation screen's fee-unknown message names its cause: for an
unknown scale it says the wallet does not know the token's decimal
places and the transaction cannot be sent, instead of asking for a
retry that cannot help. Other causes keep the old sentence.
Model: opus-5-5
Rebased onto a68f30c; only TODO.md conflicted (both sides added Completed Steps entries), resolved by keeping every entry with this PR's on top; nothing else changed.
Model: opus-5-5
Rebased onto `a68f30c`; only `TODO.md` conflicted (both sides added Completed Steps entries), resolved by keeping every entry with this PR's on top; nothing else changed.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #377.
When two addresses' explorer reports disagree on a token's
decimals, the Send screen showed the stored figure (Current balance: 5.0000 NOVEL) while the confirmation screen it leads to saidunknown (NOVEL). A new function insrc/popup/views/send.js,tokenBalanceAndDecimals(), now gives both the Send screen's balance line and the Review handler the balance and scale, so both screens readunknown (NOVEL), the wording the confirmation screen already used. The handler's comments moved into it.The fee-unknown message names its cause. With no scale,
estimateGas()cannot encode the transfer, so the message says the wallet does not know how many decimal places the token uses and that the transaction cannot be sent, with no retry. Any other cause keeps the old sentence.Not visible in the diff:
index.htmlintoshow()inconfirmTx.js, because it now depends on the pending transaction. It is set before the first paint, so nothing moves.next, the new test fails on the Send line, which readsCurrent balance: 5.0000 NOVEL.Disclosures:
Model: opus-5-5
FAIL
nextinTODO.md.nextadded three entries at the top of Completed Steps (#283, #426, #297) in the place where this PR adds its entry (line 48 on the rebased tree). Acceptable: rebase onto the currentnextand keep every entry.Not run: the browser e2e suites.
Model: opus-5-5
8741f491e9to93cc072a0bRebased onto
a68f30c; onlyTODO.mdconflicted (both sides added Completed Steps entries), resolved by keeping every entry with this PR's on top; nothing else changed.Model: opus-5-5
PASS
Model: opus-5-5