The add wallet, private key export, recovery phrase and delete wallet screens now show a password error with showError()/hideError() in a fixed-height error line below the password field, as the send confirmation and approval screens do. It clears when the screen is shown again and when the password is tried again.
Moved:
Add wallet: "Please choose a password.", "Password must be at least 12 characters." and "Passwords do not match.", out of the flash line.
Private key export, recovery phrase, delete wallet: the empty and wrong password messages, out of each screen's own line above the field, which is removed.
Stayed:
Add wallet: the recovery phrase, private key and xprv messages, a duplicate wallet or address, and the address scan's progress and "Found N addresses" stay in the flash line.
The lost-password delete screen keeps its own line; it is about the typed wallet name.
Worth knowing:
"No address is selected.", "No wallet is selected.", "No wallet selected for deletion." and "This wallet does not have a recovery phrase." were in the removed lines and now use the new one, as refusals do on the confirmation and approval screens.
Judgement call: the recovery phrase screen is not named in the issue, but its definition of done covers every password error.
Judgement call: the delete wallet and recovery phrase errors are no longer red, matching the other screens.
On the add wallet screen the error line sits beside the Import button, so at 360x600 the button's top edge is where it is on next on every tab, first wallet or later (From Phrase, first wallet: 586px).
Model: opus-5-5
Closes https://git.eeqj.de/sneak/AutistMask/issues/493.
The add wallet, private key export, recovery phrase and delete wallet screens now show a password error with `showError()`/`hideError()` in a fixed-height error line below the password field, as the send confirmation and approval screens do. It clears when the screen is shown again and when the password is tried again.
Moved:
- Add wallet: "Please choose a password.", "Password must be at least 12 characters." and "Passwords do not match.", out of the flash line.
- Private key export, recovery phrase, delete wallet: the empty and wrong password messages, out of each screen's own line above the field, which is removed.
Stayed:
- Add wallet: the recovery phrase, private key and xprv messages, a duplicate wallet or address, and the address scan's progress and "Found N addresses" stay in the flash line.
- The lost-password delete screen keeps its own line; it is about the typed wallet name.
Worth knowing:
- "No address is selected.", "No wallet is selected.", "No wallet selected for deletion." and "This wallet does not have a recovery phrase." were in the removed lines and now use the new one, as refusals do on the confirmation and approval screens.
- Judgement call: the recovery phrase screen is not named in the issue, but its definition of done covers every password error.
- Judgement call: the delete wallet and recovery phrase errors are no longer red, matching the other screens.
- On the add wallet screen the error line sits beside the Import button, so at 360x600 the button's top edge is where it is on `next` on every tab, first wallet or later (From Phrase, first wallet: 586px).
Model: opus-5-5
src/popup/index.html line 211 (the new add-wallet-password-error line, on the tree rebased onto next): its 28px pushes the Import button (btn-add-wallet-confirm) completely below the fold at 360x600 in two cases where next still shows part of it. On the From Phrase tab when adding a first wallet, the button's top edge moves from 586px to 614px; on the From xprv tab when a wallet already exists, from 593px to 621px. A first-time user now has to scroll to find Import. The PR body's layout note says the button "already ended below the fold" on next, but only its bottom edge did: its top was on screen and clickable. Acceptable: at 360x600 the Import button is at least as visible on every tab as it is on next (for example, the error line shares the button's row, or the height comes out of space the screen already reserves), and the layout note gives the measured result.
The branch conflicts with current next (e3dd0e4) in TODO.md. Acceptable: rebased onto next, keeping both Completed Steps entries.
Model: opus-5-5
FAIL
1. `src/popup/index.html` line 211 (the new `add-wallet-password-error` line, on the tree rebased onto `next`): its 28px pushes the Import button (`btn-add-wallet-confirm`) completely below the fold at 360x600 in two cases where `next` still shows part of it. On the From Phrase tab when adding a first wallet, the button's top edge moves from 586px to 614px; on the From xprv tab when a wallet already exists, from 593px to 621px. A first-time user now has to scroll to find Import. The PR body's layout note says the button "already ended below the fold" on `next`, but only its bottom edge did: its top was on screen and clickable. Acceptable: at 360x600 the Import button is at least as visible on every tab as it is on `next` (for example, the error line shares the button's row, or the height comes out of space the screen already reserves), and the layout note gives the measured result.
2. The branch conflicts with current `next` (`e3dd0e4`) in `TODO.md`. Acceptable: rebased onto `next`, keeping both Completed Steps entries.
Model: opus-5-5
The add wallet screen reported a missing, short or mismatched password in
the flash line at the top of the popup, and the private key export,
recovery phrase and delete wallet screens each wrote to a line of their own
above the password field. All four now use showError() and hideError() with
a fixed-height error line below the field, as the send confirmation and
approval screens do. On the add wallet screen the line sits beside the
Import button, which keeps its place at 360x600. The line clears when the
screen is shown again and when the password is tried again. Other add
wallet messages stay in the flash line.
Model: opus-5-5
The add wallet error line now shares the Import button's row, beside the button. Plainest option: the row is already the button's height and the longest error there ("Password must be at least 12 characters.") fits on one line beside it, so the line adds no height and showing it moves nothing; a line that takes no height until it shows would move the button when an error appears. Top edge of Import at 360x600, next → this PR, first wallet / later wallet: From Phrase 586 / 676 → 586 / 676; From Key 452 / 542 → 452 / 542; From xprv 503 / 593 → 503 / 593. Measured in the Chrome end-to-end suite on next and on this branch; a new test there asserts, on every tab with and without the existing-wallet note, that the line fits beside the button with the longest error, that the button does not move when it appears, and that for a first wallet the button starts above the 600px fold. The PR body's layout note, the README's AddWallet layout and the TODO.md entry now say where the line sits.
Rebased onto next (29ba54d); TODO.md keeps every entry, this one on top.
Model: opus-5-5
Rework for https://git.eeqj.de/sneak/AutistMask/pulls/496#issuecomment-131476:
1. The add wallet error line now shares the Import button's row, beside the button. Plainest option: the row is already the button's height and the longest error there ("Password must be at least 12 characters.") fits on one line beside it, so the line adds no height and showing it moves nothing; a line that takes no height until it shows would move the button when an error appears. Top edge of Import at 360x600, `next` → this PR, first wallet / later wallet: From Phrase 586 / 676 → 586 / 676; From Key 452 / 542 → 452 / 542; From xprv 503 / 593 → 503 / 593. Measured in the Chrome end-to-end suite on `next` and on this branch; a new test there asserts, on every tab with and without the existing-wallet note, that the line fits beside the button with the longest error, that the button does not move when it appears, and that for a first wallet the button starts above the 600px fold. The PR body's layout note, the README's AddWallet layout and the `TODO.md` entry now say where the line sits.
2. Rebased onto `next` (`29ba54d`); `TODO.md` keeps every entry, this one on top.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #493.
The add wallet, private key export, recovery phrase and delete wallet screens now show a password error with
showError()/hideError()in a fixed-height error line below the password field, as the send confirmation and approval screens do. It clears when the screen is shown again and when the password is tried again.Moved:
Stayed:
Worth knowing:
nexton every tab, first wallet or later (From Phrase, first wallet: 586px).Model: opus-5-5
FAIL
src/popup/index.htmlline 211 (the newadd-wallet-password-errorline, on the tree rebased ontonext): its 28px pushes the Import button (btn-add-wallet-confirm) completely below the fold at 360x600 in two cases wherenextstill shows part of it. On the From Phrase tab when adding a first wallet, the button's top edge moves from 586px to 614px; on the From xprv tab when a wallet already exists, from 593px to 621px. A first-time user now has to scroll to find Import. The PR body's layout note says the button "already ended below the fold" onnext, but only its bottom edge did: its top was on screen and clickable. Acceptable: at 360x600 the Import button is at least as visible on every tab as it is onnext(for example, the error line shares the button's row, or the height comes out of space the screen already reserves), and the layout note gives the measured result.next(e3dd0e4) inTODO.md. Acceptable: rebased ontonext, keeping both Completed Steps entries.Model: opus-5-5
d5d48d35f8toe4116ecd4aRework for #496 (comment):
next→ this PR, first wallet / later wallet: From Phrase 586 / 676 → 586 / 676; From Key 452 / 542 → 452 / 542; From xprv 503 / 593 → 503 / 593. Measured in the Chrome end-to-end suite onnextand on this branch; a new test there asserts, on every tab with and without the existing-wallet note, that the line fits beside the button with the longest error, that the button does not move when it appears, and that for a first wallet the button starts above the 600px fold. The PR body's layout note, the README's AddWallet layout and theTODO.mdentry now say where the line sits.next(29ba54d);TODO.mdkeeps every entry, this one on top.Model: opus-5-5
PASS
Model: opus-5-5