Chrome now draws the popup's text at the 14px that text-sm on body declares, as Firefox does.
Cause: the stylesheet Chrome adds to extension pages, the one #457 dealt with for the font, also sets body to font-size: 75% outside any cascade layer, so it beat Tailwind's text-sm. body now carries text-sm!, the important form, beside font-mono!, and the comment above the body tag covers both.
Layout: at 14px no popup screen has text that runs past its box or is clipped where it was not at 12px; screens only grow taller. On the add wallet screen that growth pushed Import below the fold at 360x600, because the recovery phrase instruction takes a third line, and the existing check from #493 fails on it. The die button now shares the instruction's row instead of taking a row of its own, which brings Import back above the fold.
Tests: each browser suite checks that body computes to 14px. The Chrome one fails without the fix.
What the diff does not show:
All Chrome text that takes its size from body is larger now, so screens already taller than 600px scroll a little further. That includes the transaction approval window, which is opened at 360x600.
Import still ends below the fold on that screen. The check asks only that it start above it, as it did at 12px.
Judgement call: the Firefox check goes beyond the issue, as it did in #457.
Model: opus-5-5
Chrome now draws the popup's text at the 14px that `text-sm` on `body` declares, as Firefox does.
Cause: the stylesheet Chrome adds to extension pages, the one https://git.eeqj.de/sneak/AutistMask/pulls/457 dealt with for the font, also sets `body` to `font-size: 75%` outside any cascade layer, so it beat Tailwind's `text-sm`. `body` now carries `text-sm!`, the important form, beside `font-mono!`, and the comment above the body tag covers both.
Layout: at 14px no popup screen has text that runs past its box or is clipped where it was not at 12px; screens only grow taller. On the add wallet screen that growth pushed Import below the fold at 360x600, because the recovery phrase instruction takes a third line, and the existing check from https://git.eeqj.de/sneak/AutistMask/issues/493 fails on it. The die button now shares the instruction's row instead of taking a row of its own, which brings Import back above the fold.
Tests: each browser suite checks that `body` computes to 14px. The Chrome one fails without the fix.
What the diff does not show:
- All Chrome text that takes its size from `body` is larger now, so screens already taller than 600px scroll a little further. That includes the transaction approval window, which is opened at 360x600.
- Import still ends below the fold on that screen. The check asks only that it start above it, as it did at 12px.
Judgement call: the Firefox check goes beyond the issue, as it did in https://git.eeqj.de/sneak/AutistMask/pulls/457.
Model: opus-5-5
Chrome gives extension pages a stylesheet of its own that sets body to
75%, outside any cascade layer, so it beat Tailwind's text-sm and Chrome
drew the popup at 12px where Firefox draws 14px. body now carries
text-sm!, the important form, as it already carries font-mono!. Both
browser suites check that body computes to 14px.
At 14px the recovery phrase instruction on the add wallet screen takes a
third line, which pushed Import below the fold at 360x600. The die button
now shares the instruction's row instead of taking a row of its own.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Chrome now draws the popup's text at the 14px that
text-smonbodydeclares, as Firefox does.Cause: the stylesheet Chrome adds to extension pages, the one #457 dealt with for the font, also sets
bodytofont-size: 75%outside any cascade layer, so it beat Tailwind'stext-sm.bodynow carriestext-sm!, the important form, besidefont-mono!, and the comment above the body tag covers both.Layout: at 14px no popup screen has text that runs past its box or is clipped where it was not at 12px; screens only grow taller. On the add wallet screen that growth pushed Import below the fold at 360x600, because the recovery phrase instruction takes a third line, and the existing check from #493 fails on it. The die button now shares the instruction's row instead of taking a row of its own, which brings Import back above the fold.
Tests: each browser suite checks that
bodycomputes to 14px. The Chrome one fails without the fix.What the diff does not show:
bodyis larger now, so screens already taller than 600px scroll a little further. That includes the transaction approval window, which is opened at 360x600.Judgement call: the Firefox check goes beyond the issue, as it did in #457.
Model: opus-5-5
PASS: this implements #456 as planned and is ready to merge into
next.Model: opus-5-5