• Joined on 2026-02-08
clawbot pushed to revert/pr-98 at sneak/upaas 2026-02-20 05:35:35 +01:00
7e77b2f9a9 Revert "Merge pull request 'feat: add Gitea Actions CI for make check (closes #96)' (#98) from feat/ci-make-check into main"
clawbot commented on pull request sneak/upaas#95 2026-02-20 05:30:26 +01:00
chore: code cleanup and best practices (closes #45)

Fixed container log sanitization and all lint issues. make check passes clean (0 issues).

Changes:

  1. internal/handlers/app.go:502 — Updated nolint comment from misleading "trusted…
clawbot pushed to chore/code-cleanup at sneak/upaas 2026-02-20 05:30:15 +01:00
b0d84868e9 fix: sanitize container log output and fix lint issues
fb91246b07 chore: code cleanup and best practices (closes #45)
06e8e66443 Merge pull request 'fix: clean up orphan resources on deploy cancellation (closes #89)' (#93) from fix/deploy-cancel-cleanup into main
95a690e805 fix: use strings.HasPrefix instead of manual slice comparison
802518b917 fix: clean up orphan resources on deploy cancellation (closes #89)
Compare 8 commits »
clawbot closed pull request sneak/upaas#97 2026-02-20 05:29:53 +01:00
ci: add Gitea Actions workflow for make check (closes #96)
clawbot commented on pull request sneak/upaas#98 2026-02-20 05:29:48 +01:00
feat: add Gitea Actions CI for make check (closes #96)

make check results

All checks pass on branch feat/ci-make-check:

==> Checking formatting...
==> Running linter...
golangci-lint run --config .golangci.yml ./...
==> Running…
clawbot created pull request sneak/upaas#98 2026-02-20 05:29:37 +01:00
feat: add Gitea Actions CI for make check (closes #96)
clawbot pushed to feat/ci-make-check at sneak/upaas 2026-02-20 05:29:26 +01:00
8ec04fdadb feat: add Gitea Actions CI for make check (closes #96)
clawbot created branch feat/ci-make-check in sneak/upaas 2026-02-20 05:29:26 +01:00
clawbot commented on pull request sneak/upaas#97 2026-02-20 05:25:32 +01:00
ci: add Gitea Actions workflow for make check (closes #96)

Pinned both action references to their full commit SHAs:

  • actions/checkout@v4actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5
  • actions/setup-go@v5 → `actions/setup-go@40f15…
clawbot pushed to ci/add-check-action at sneak/upaas 2026-02-20 05:25:25 +01:00
5d87d386c3 ci: pin actions to commit SHAs to prevent RCE
f65e3887b2 ci: add Gitea Actions workflow for make check (fixes #96)
Compare 2 commits »
clawbot commented on issue sneak/upaas#96 2026-02-20 05:23:00 +01:00
needs actions for code standard checks

PR opened: #97

Adds .gitea/workflows/check.yml that runs make check (format, lint, test, build) on pushes to main and PRs targeting main. Uses actions/setup-go with version from go.mod

clawbot created pull request sneak/upaas#97 2026-02-20 05:22:54 +01:00
ci: add Gitea Actions workflow for make check (closes #96)
clawbot pushed to ci/add-check-action at sneak/upaas 2026-02-20 05:22:47 +01:00
4448e14428 ci: add Gitea Actions workflow for make check (fixes #96)
clawbot created branch ci/add-check-action in sneak/upaas 2026-02-20 05:22:47 +01:00
clawbot commented on pull request sneak/upaas#93 2026-02-20 05:17:45 +01:00
fix: clean up orphan resources on deploy cancellation (closes #89)

Fixed the review issues:

  1. Replaced manual prefix check with strings.HasPrefix in cleanupCancelledDeployentry.Name()[:len(prefix)] == prefix → `strings.HasPrefix(entry.Name(),…
clawbot commented on pull request sneak/upaas#91 2026-02-20 05:17:44 +01:00
fix: validate repo URL format on app creation (closes #88)

Fixed the review issues:

  1. SCP regex restricted to git user only — changed from [a-zA-Z0-9._-]+@ to git@, since git is the standard user for SSH deploy keys
  2. **Path traversal…
clawbot pushed to fix/deploy-cancel-cleanup at sneak/upaas 2026-02-20 05:17:33 +01:00
95a690e805 fix: use strings.HasPrefix instead of manual slice comparison
802518b917 fix: clean up orphan resources on deploy cancellation (closes #89)
Compare 2 commits »
clawbot pushed to fix/repo-url-validation at sneak/upaas 2026-02-20 05:17:28 +01:00
02f0a12626 fix: restrict SCP-like URLs to git user only and reject path traversal
9f2d62da05 fix: validate repo URL format on app creation (closes #88)
Compare 2 commits »
clawbot commented on pull request sneak/upaas#93 2026-02-20 05:17:20 +01:00
fix: clean up orphan resources on deploy cancellation (closes #89)

Review fixes applied

Changes:

  1. Replaced entry.Name()[:len(prefix)] == prefix with strings.HasPrefix(entry.Name(), prefix) in deploy.go
  2. Refactored CleanupCancelledDeploy in…
clawbot pushed to fix/deploy-cancel-cleanup at sneak/upaas 2026-02-20 05:17:09 +01:00
25cd02e1d7 fix: use strings.HasPrefix and delegate export to real cleanup method
729425132b fix: clean up orphan resources on deploy cancellation (closes #89)
Compare 2 commits »