Settings, the RPC endpoint save in src/popup/views/settings.js, against an open popup following a network switch saved elsewhere (followNetworkSwitch() in src/popup/index.js).
What happens
The user saves a checked RPC URL in Settings. If a follow of a switch saved elsewhere lands between Settings setting state.rpcUrl and that save, the follow replaces the URL with the new network's, the save writes that, and Settings still flashes "Saved." The user's edit is lost while the screen says it was saved. It takes a popup open as a full page and an approval in another window within milliseconds of the save.
What should happen
"Saved." is shown only for what was stored: an edit made while a follow lands is either stored for the network it was made on or refused with a sentence saying the network changed.
Severity: minor
Definition of done
An RPC edit interleaved with a follow is never lost behind a "Saved." flash.
A test landing the follow between the edit and its save, failing on next.
Model: opus-5-5
Seen by the review of https://git.eeqj.de/sneak/AutistMask/pulls/654.
## Where
Settings, the RPC endpoint save in `src/popup/views/settings.js`, against an open popup following a network switch saved elsewhere (`followNetworkSwitch()` in `src/popup/index.js`).
## What happens
The user saves a checked RPC URL in Settings. If a follow of a switch saved elsewhere lands between Settings setting `state.rpcUrl` and that save, the follow replaces the URL with the new network's, the save writes that, and Settings still flashes "Saved." The user's edit is lost while the screen says it was saved. It takes a popup open as a full page and an approval in another window within milliseconds of the save.
## What should happen
"Saved." is shown only for what was stored: an edit made while a follow lands is either stored for the network it was made on or refused with a sentence saying the network changed.
Severity: minor
## Definition of done
- [ ] An RPC edit interleaved with a follow is never lost behind a "Saved." flash.
- [ ] A test landing the follow between the edit and its save, failing on `next`.
Model: opus-5-5
clawbot
self-assigned this 2026-10-21 04:26:52 +02:00
Plan: one PR to next. The RPC endpoint save in src/popup/views/settings.js remembers the network the edit was made on. If an open popup follows a switch saved elsewhere before the save (followStoredSettings() in src/popup/index.js, formerly followNetworkSwitch()), the save is refused. A plain sentence says the network changed, and "Saved." is never shown for a URL that was not stored. A Jest test lands the follow between the edit and its save, and fails on next.
Model: opus-5-5
Plan: one PR to `next`. The RPC endpoint save in `src/popup/views/settings.js` remembers the network the edit was made on. If an open popup follows a switch saved elsewhere before the save (`followStoredSettings()` in `src/popup/index.js`, formerly `followNetworkSwitch()`), the save is refused. A plain sentence says the network changed, and "Saved." is never shown for a URL that was not stored. A Jest test lands the follow between the edit and its save, and fails on `next`.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Seen by the review of #654.
Where
Settings, the RPC endpoint save in
src/popup/views/settings.js, against an open popup following a network switch saved elsewhere (followNetworkSwitch()insrc/popup/index.js).What happens
The user saves a checked RPC URL in Settings. If a follow of a switch saved elsewhere lands between Settings setting
state.rpcUrland that save, the follow replaces the URL with the new network's, the save writes that, and Settings still flashes "Saved." The user's edit is lost while the screen says it was saved. It takes a popup open as a full page and an approval in another window within milliseconds of the save.What should happen
"Saved." is shown only for what was stored: an edit made while a follow lands is either stored for the network it was made on or refused with a sentence saying the network changed.
Severity: minor
Definition of done
next.Model: opus-5-5
Plan: one PR to
next. The RPC endpoint save insrc/popup/views/settings.jsremembers the network the edit was made on. If an open popup follows a switch saved elsewhere before the save (followStoredSettings()insrc/popup/index.js, formerlyfollowNetworkSwitch()), the save is refused. A plain sentence says the network changed, and "Saved." is never shown for a URL that was not stored. A Jest test lands the follow between the edit and its save, and fails onnext.Model: opus-5-5