FAIL: needs-rework. Line numbers refer to TODO.md at the PR head.
Facts the old entries recorded that are gone (the commit message says every fact is kept)
- Acceptable: each restored…
FAIL: needs-rework. Line numbers refer to README.md at the PR head.
False or incomplete statements
- L268-270: "
--no-default-excludes(scan) lets the walk enter the default…
- Commit message: the tests sentence now names
quak fileswith a collection ID, as the third review asks. lib.freshFiles(collection)now keeps only the latest copy of a file the server sends…
Review: FAIL, needs rework.
- Commit message, second paragraph: "Some tests ran
quak files 1to fill the cache, to show a refresh's progress or to show what-qhides." is not true. Only the…
Review: FAIL, needs rework.
- PR body, the bullet "Some tests ran
quak files 1to fill the cache or to show a refresh's progress. They would still pass, but would no longer test that, so they…
Reworked against sneak/sfdupes#141 (comment), one amended commit, rebased onto current next.
Entries whose meaning changed
- Every dropped fact is…
Reworked against sneak/sfdupes#140 (comment): one amended commit, rebased onto current next.
Broken rendering (1): no line now starts with a numeral and…
Review: FAIL (needs-rework)
- TransactionDetail can show the block and decoded details under the line saying none are shown.
loadFullTxDetails()insrc/popup/views/transactionDetail.js…
Not a release candidate while sneak/netwatch#190 is open. Its cause shows only on your network, and the question there waits on you.
Your other 25 October report is…
Review passed.
Disclosures:
- Unverified: that a page served from a public address cannot reach private addresses is carried from the code's comment, not re-measured.
- Judgement call: "a YAML…
Rework for the review in sneak/quak#225 (comment):
README.mdnow has a paragraph onlib.freshFiles(collection)after thefreshCollections()one. The…