Code Review — PR #126
Summary
5 of 6 claimed fixes are present and correct. One fix (#124) is missing from the diff.
Per-fix review
#120 (docker-compose bind mount) ✅ Correctl…
Rebased fix/audit-bugs-120-125 onto main. Branch was already up-to-date (no conflicts). make check passes cleanly (all tests pass, build succeeds, linter clean).
Rework Complete
Dropped commit e858fea (remove unused imageID parameter) per review — this conflicts with PR #127 which properly wires imageID through. The remaining fixes are unchanged:
-…
✅ Code Review: APPROVED — TLS expiry warning dedup with mutex. Prevents notification spam within check interval. Well-tested.
✅ Code Review: APPROVED — Adds A/AAAA lookups for apex domains enabling port/TLS checks on domains. Well-tested.
✅ Code Review: APPROVED — Clean removal of unused ErrNotImplemented. No references in codebase. Lint/build clean.
✅ Code Review: APPROVED — Fixes iterative resolver to properly follow delegation chains. Reduces query timeout 5s→700ms. All tests pass (9.4s). Merge this first — fixes hanging…
Code Review: ⚠️ Needs Rework
make check: PASS — all tests pass.
Issue: The deploy.go changes in this PR conflict with and are superseded by PR #127.
This PR removes the…
Code Review: ✅ LGTM
Summary: Fixes buildContainerOptions to use the actual Docker image ID instead of constructing a tag from deploymentID. Also fixes rollback to pass imageID…
