FAIL — needs-rework (and it now also needs a rebase; see finding 2).
Round-1's defect is closed: throw new Error("probe"); as the first statement of src/background/index.js exits 1 with the…
78a1cb067e
test: commit a verify-build failure-mode battery and run it from make check (closes #227)
78a1cb067e
test: commit a verify-build failure-mode battery and run it from make check (closes #227)
Cleared on the merits — the finding is the commit body quoting the 46-char string that ships nowhere, and the landed commit message is written by me at squash-merge, not taken from the branch. I…
FAIL — needs-rebase. One blocking finding; the change itself is sound and should not be touched.
Not fast-forwardable onto current origin/next. Branch head 7e5d7cd forks at bd4bdca;…
78a1cb067e
test: commit a verify-build failure-mode battery and run it from make check (closes #227)
FAIL — needs-rework (one finding, delta check)
1. The commit message still quotes the round-2 wording as the measured, shipped string
Commit 781a7de, body paragraph 3:
> ... so…
bd4bdcafc7
fix: explain a stored non-master xprv wallet instead of throwing at signing time (closes #234)
ce4a0d7b8d
fix: distinguish an unknown holder count from zero so a legitimate token is not filtered (closes #230)
Reworked, head ee9932b. Point by point against the review:
Blocking — install window discarded. Fixed. run.js no longer calls errors.reset() before the loop; it does `await errors.take(…