display issues #133

Closed
opened 2026-10-22 19:36:39 +02:00 by sneak · 3 comments
Owner
walk /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.zsh/plugins/chucknorris/fortunes: open /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.zsh/plugins/chucknorris/fortunes: no such file or directory
walk /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.zsh/plugins/hitchhiker/fortunes: open /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.zsh/plugins/hitchhiker/fortunes: no such file or directory
walk /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.zsh/plugins/zsh-navigation-tools/doc: open /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.zsh/plugins/zsh-navigation-tools/doc: no such file or directory
walk /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.zsh/plugins/zsh-navigation-tools/.config: open /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.zsh/plugins/zsh-navigation-tools/.config: no such file or directory
walk /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.vim/autoload: open /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.vim/autoload: no such file or directory
⠹ [2/5] walk: 29524253 files, 1459 files/s, elapsed 41m43s, eta unknown
[3/5] hash: [11203/28444548], 102 files/s, elapsed 2m2s, eta 86h0m38s   0% |          |

The missing files during the walk should not be displayed, walking definitionally is determining which files exist, and missing files are not an error.

The "3/5 hash" phase doesn't have a little spinner in the first column, and as the length of the eta string changes, the progress bar moves around. the progress bar should be fixed length and right-aligned.

ETA is not a duration - ETA is estimated time of completion (arrival). the label for the duration remaining is "remain".

``` walk /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.zsh/plugins/chucknorris/fortunes: open /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.zsh/plugins/chucknorris/fortunes: no such file or directory walk /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.zsh/plugins/hitchhiker/fortunes: open /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.zsh/plugins/hitchhiker/fortunes: no such file or directory walk /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.zsh/plugins/zsh-navigation-tools/doc: open /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.zsh/plugins/zsh-navigation-tools/doc: no such file or directory walk /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.zsh/plugins/zsh-navigation-tools/.config: open /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.zsh/plugins/zsh-navigation-tools/.config: no such file or directory walk /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.vim/autoload: open /srv/pool.2024.04/backups/2024-08-23-cyberdyne-prewipe-delete-after-2024-12-31.backup/.vim/autoload: no such file or directory ⠹ [2/5] walk: 29524253 files, 1459 files/s, elapsed 41m43s, eta unknown [3/5] hash: [11203/28444548], 102 files/s, elapsed 2m2s, eta 86h0m38s 0% | | ``` The missing files during the walk should not be displayed, walking definitionally is determining which files exist, and missing files are not an error. The "3/5 hash" phase doesn't have a little spinner in the first column, and as the length of the eta string changes, the progress bar moves around. the progress bar should be fixed length and right-aligned. ETA is not a duration - ETA is estimated time of completion (arrival). the label for the duration remaining is "remain".
Collaborator

Recorded, three fixes: a file that disappears during the walk is skipped silently, not reported; the hash phase gets the spinner the other phases have, and a fixed-length bar aligned to the right edge so it no longer moves; and "eta" becomes "remain" wherever it shows time left (an ETA, if shown, is a clock time). sfdupes' manager fixes these when the fleet restarts at 23:00 UTC on 25 October.

Model: opus-5-5

Recorded, three fixes: a file that disappears during the walk is skipped silently, not reported; the hash phase gets the spinner the other phases have, and a fixed-length bar aligned to the right edge so it no longer moves; and "eta" becomes "remain" wherever it shows time left (an ETA, if shown, is a clock time). sfdupes' manager fixes these when the fleet restarts at 23:00 UTC on 25 October. Model: opus-5-5
clawbot self-assigned this 2026-10-22 19:51:12 +02:00
Collaborator

Plan, one PR into next:

  • A file or directory that no longer exists when the scan reaches it is skipped without a line. Judgement call: this also covers a file that is gone by the time the hash phase opens it, since a missing file is not an error anywhere in the scan. Every other error is still reported.
  • Every phase's progress line starts with the spinner, the hash phase included.
  • The progress bar has a fixed length and sits at the right edge, so a time string that changes length never moves it.
  • The time left is labelled remain.

Model: opus-5-5

Plan, one PR into `next`: - A file or directory that no longer exists when the scan reaches it is skipped without a line. Judgement call: this also covers a file that is gone by the time the hash phase opens it, since a missing file is not an error anywhere in the scan. Every other error is still reported. - Every phase's progress line starts with the spinner, the hash phase included. - The progress bar has a fixed length and sits at the right edge, so a time string that changes length never moves it. - The time left is labelled `remain`. Model: opus-5-5
Collaborator

Built in #139, awaiting review. Beyond the plan: when the first of several hard links to a file is gone, the hash phase reads the next link, and an operand removed after the scan starts is also passed over without a line.

Model: opus-5-5

Built in https://git.eeqj.de/sneak/sfdupes/pulls/139, awaiting review. Beyond the plan: when the first of several hard links to a file is gone, the hash phase reads the next link, and an operand removed after the scan starts is also passed over without a line. Model: opus-5-5
Sign in to join this conversation.
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/sfdupes#133