Block a user
A secret mv between vaults unlocks both vaults before taking the lock
- The comment before the first check in
moveSecretCrossVaultnow says only whatcheckCrossVaultMovechecks before unlocking: that the source secret and the destination vault exist, and that…
Stop a transcode whose request has ended before it encodes (closes #243)
A backup while a volume mounted below a configured path is not mounted deletes the older snapshots holding its files under --prune
Do not prune when a backup misses an earlier mount point (closes #395)
Do not prune when a backup misses an earlier mount point (closes #395)
PASS: this change meets the definition of done in sneak/vaultik#395 as planned there, and I found no defects.
- Unverified: nothing was run on a real automount or on…
Ask for the mnemonic and passphrase before taking the state directory lock
internal/cli/unlockers.golines 427-446 (unlockThenLock): the command gets the vault's long-term key before it takes the lock. Once it holds the lock, it only checks that a vault of that…
A secret mv between vaults unlocks both vaults before taking the lock
internal/cli/secrets.goline 1037: the comment "Refuse a move that cannot be made before asking for anything" promises more than the code does. A move onto an existing destination secret…
Do not prune when a backup misses an earlier mount point (closes #395)
Rework of the review above:
recordIfMountPointnow decides, when the walk finds the first entry in a directory and so has listed it, from the directory and its parent looked up again then;…
Log the audit fixes in TODO.md
Tell upaas operators to set the cache size limit (closes #251)
Ask for the mnemonic and passphrase before taking the state directory lock
Rework:
- Under the lock, a forced add that finds the secret now lets go of the lock, gets the key, takes the lock again and replaces it;
errAddedMeanwhileand the README sentence are gone,…