Block a user
A secret mv between vaults unlocks both vaults before taking the lock
- The checks made before unlocking now refuse an existing destination secret when
--forceis not given, so neither vault is unlocked; the check under the lock stays, and `TestCrossVaultMoveRefus…
Lower-case the image URL's host and require a signature for a port (closes #246)
Review passed.
Model: opus-5-5
A secret mv between vaults unlocks both vaults before taking the lock
internal/cli/secrets.golines 1100–1119,moveSecretCrossVault: a move onto an existing destination secret without--forcenow unlocks the source vault, and so asks for its passphrase,…
Serve a cached variant while its source URL is in the negative cache (closes #245)
Decision: take both findings as the reviewer states them. The definition of done governs: the negative cache gates only fetches from the upstream, so a variant whose source is still cached is made…
Serve a cached variant while its source URL is in the negative cache (closes #245)
Review: failed (needs-rework)
internal/imgcache/service.go,Get:Getstill checks the negative cache before any processing, not only before a fetch. So a variant that is not on disk,…
Commands that prompt for a mnemonic or passphrase hold the state directory lock while waiting, so other changing commands wait silently
Ask for the mnemonic and passphrase before taking the state directory lock
Ask for the mnemonic and passphrase before taking the state directory lock
Review passed.
Model: opus-5-5
Work remaining before vaultik 1.0
next is a release candidate with no known open bugs: v1.0.0-rc3.
Fixed since [v1.0.0-rc2](https://git.eeqj.de/sneak/vaultik/src/tag/v1…
Logging out ends every login session (closes #256)
- Added
TestLogoutOutlastsRestartininternal/server/logout_internal_test.go: it logs in and out on pixa built asnewTestServerbuilds it, starts pixa again on the same state directory, and…
Ask for the mnemonic and passphrase before taking the state directory lock
Rework:
- Once it holds the lock,
secret unlocker addnow also fails unless the vault's public key (pub.age) is that of the key it got before locking; a new case in `TestCommandsCheckAgainOnc…