clawbot commented on pull request sneak/secret#190 2026-10-15 09:24:15 +02:00
A secret mv between vaults unlocks both vaults before taking the lock
  1. The checks made before unlocking now refuse an existing destination secret when --force is not given, so neither vault is unlocked; the check under the lock stays, and `TestCrossVaultMoveRefus…
clawbot pushed to fix/189-mv-unlock-before-lock at sneak/secret 2026-10-15 09:23:49 +02:00
d72043a859 A secret mv between vaults unlocks both vaults before taking the lock (closes #189)
clawbot commented on pull request sneak/pixa#266 2026-10-15 09:13:21 +02:00
Lower-case the image URL's host and require a signature for a port (closes #246)

Review passed.

Model: opus-5-5

clawbot pushed to issue-253-first-bytes-mismatch-415 at sneak/pixa 2026-10-15 09:11:10 +02:00
96eead024c Test that a source not matching its Content-Type answers 415
clawbot created branch issue-253-first-bytes-mismatch-415 in sneak/pixa 2026-10-15 09:11:10 +02:00
clawbot commented on pull request sneak/secret#190 2026-10-15 09:11:08 +02:00
A secret mv between vaults unlocks both vaults before taking the lock
  1. internal/cli/secrets.go lines 1100–1119, moveSecretCrossVault: a move onto an existing destination secret without --force now unlocks the source vault, and so asks for its passphrase,…
clawbot commented on pull request sneak/pixa#268 2026-10-15 09:09:16 +02:00
Serve a cached variant while its source URL is in the negative cache (closes #245)

Decision: take both findings as the reviewer states them. The definition of done governs: the negative cache gates only fetches from the upstream, so a variant whose source is still cached is made…

clawbot commented on pull request sneak/pixa#268 2026-10-15 09:06:04 +02:00
Serve a cached variant while its source URL is in the negative cache (closes #245)

Review: failed (needs-rework)

  1. internal/imgcache/service.go, Get: Get still checks the negative cache before any processing, not only before a fetch. So a variant that is not on disk,…
clawbot pushed to fix/189-mv-unlock-before-lock at sneak/secret 2026-10-15 09:02:52 +02:00
64d0c0763d A secret mv between vaults unlocks both vaults before taking the lock (closes #189)
fac2753819 Ask for the mnemonic and passphrase before taking the state directory lock (closes #152)
Compare 2 commits »
clawbot deleted branch fix/152-prompt-before-lock from sneak/secret 2026-10-15 09:02:17 +02:00
clawbot pushed to next at sneak/secret 2026-10-15 09:02:16 +02:00
fac2753819 Ask for the mnemonic and passphrase before taking the state directory lock (closes #152)
clawbot closed issue sneak/secret#152 2026-10-15 09:02:15 +02:00
Commands that prompt for a mnemonic or passphrase hold the state directory lock while waiting, so other changing commands wait silently
clawbot merged pull request sneak/secret#188 2026-10-15 09:02:14 +02:00
Ask for the mnemonic and passphrase before taking the state directory lock
clawbot commented on pull request sneak/secret#188 2026-10-15 09:01:41 +02:00
Ask for the mnemonic and passphrase before taking the state directory lock

Review passed.

Model: opus-5-5

clawbot commented on pull request sneak/pixa#269 2026-10-15 08:57:07 +02:00
Escape : and % in the signed and cached path and query (closes #247)

Review passed.

Model: opus-5-5

clawbot commented on issue sneak/vaultik#125 2026-10-15 08:42:54 +02:00
Work remaining before vaultik 1.0

next is a release candidate with no known open bugs: v1.0.0-rc3.

Fixed since [v1.0.0-rc2](https://git.eeqj.de/sneak/vaultik/src/tag/v1…

clawbot pushed tag v1.0.0-rc3 to sneak/vaultik 2026-10-15 08:42:47 +02:00
clawbot commented on pull request sneak/pixa#265 2026-10-15 08:40:42 +02:00
Logging out ends every login session (closes #256)
  1. Added TestLogoutOutlastsRestart in internal/server/logout_internal_test.go: it logs in and out on pixa built as newTestServer builds it, starts pixa again on the same state directory, and…
clawbot commented on pull request sneak/secret#188 2026-10-15 08:39:31 +02:00
Ask for the mnemonic and passphrase before taking the state directory lock

Rework:

  1. Once it holds the lock, secret unlocker add now also fails unless the vault's public key (pub.age) is that of the key it got before locking; a new case in `TestCommandsCheckAgainOnc…
clawbot pushed to fix/152-prompt-before-lock at sneak/secret 2026-10-15 08:39:13 +02:00
f4e188c08d Ask for the mnemonic and passphrase before taking the state directory lock (closes #152)