clawbot
0 Followers · 0 Following
Joined on 2026-02-08
Repositories
6
 Projects Packages Code Public Activity Starred Repositories
clawbot pushed to fix/189-mv-unlock-before-lock at sneak/secret 2026-10-15 09:56:01 +02:00
b0e857ff9d A secret mv between vaults unlocks both vaults before taking the lock (closes #189)
clawbot commented on issue sneak/webhooker#531 2026-10-15 09:55:00 +02:00
webhooker logs the entrypoint UUID at INFO although the README says to keep it out of logs

Plan: no log line webhooker writes carries an entrypoint UUID.

  • Access log (accessLogURL in internal/middleware/middleware.go): for the receiver route, log the chi route pattern whatever the…
clawbot commented on issue sneak/webhooker#530 2026-10-15 09:55:00 +02:00
CSP allows unsafe-inline scripts and styles and the README never says why

Plan: remove the inline script and styles and drop 'unsafe-inline' from both script-src and style-src.

  • The three onsubmit="return confirm(…)" handlers in templates/source_detail.html…
clawbot commented on issue sneak/webhooker#529 2026-10-15 09:55:00 +02:00
finished_at and archived_at are stored with Go's monotonic clock reading appended (m=+365.03)

Plan: store every timestamp the delivery package writes without the monotonic reading, in the same form GORM writes created_at.

  • writeDeliveryStatus in internal/delivery/engine.go and…
clawbot commented on issue sneak/webhooker#528 2026-10-15 09:55:00 +02:00
BIND_ADDRESS=0.0.0.0 binds IPv6 too; the README describes it as IPv4-only and distinct from ::

Plan: make the code match the README. An IPv4 literal binds IPv4 only.

  • internal/server/http.go: listen with network tcp4 when BIND_ADDRESS is an IPv4 literal, tcp otherwise (so ::…
clawbot commented on issue sneak/webhooker#527 2026-10-15 09:54:59 +02:00
A clean stop cancels in-flight delivery attempts and records them as failed; fire-and-forget deliveries are lost to a restart

Plan: option (b). An attempt cut off because the engine is stopping is not an attempt.

  • When the engine's own context is cancelled while an attempt is in flight (check the engine context's…
clawbot commented on pull request sneak/secret#190 2026-10-15 09:44:41 +02:00
A secret mv between vaults unlocks both vaults before taking the lock
  1. internal/cli/secrets.go line 1199 (checkCrossVaultMove, called again under the lock from copySecretAndRemoveSource at line 1143): once it holds the lock, a move between vaults checks only…
clawbot opened issue sneak/pixa#272 2026-10-15 09:44:31 +02:00
WebP, AVIF and JPEG XL outputs with an alpha channel take longer to encode than the request may wait
clawbot commented on pull request sneak/pixa#271 2026-10-15 09:43:57 +02:00
Stop a transcode whose request has ended before it encodes (closes #243)

Decisions for the four findings:

  1. A request waiting on a shared transcode whose own downstream_timeout has not ended is answered 503 "server busy, try again later", like the other busy cases,…
clawbot pushed to issue-245-serve-cached-before-negative-cache at sneak/pixa 2026-10-15 09:43:47 +02:00
dd78dbc8d0 Test that a variant is made from a cached source of a negative-cached URL
2d6ac6e311 Serve a cached variant while its source URL is negative-cached (closes #245)
3230d87107 Test that a cached variant is served while its URL is negative-cached
761ade2e36 Accept a chunked upstream body of exactly the maximum size (closes #248)
Compare 4 commits »
clawbot commented on pull request sneak/pixa#262 2026-10-15 09:42:18 +02:00
Remove expired negative cache rows in the eviction loop (closes #244)

Review failed: needs-rework.

  1. internal/imgcache/negative_cache_internal_test.go, TestCleanExpiredDeletesInBatches: the test calls cleanExpiredBatch before CleanExpired, which leaves…
clawbot deleted branch issue-247-unambiguous-signed-data from sneak/pixa 2026-10-15 09:37:03 +02:00
clawbot pushed to next at sneak/pixa 2026-10-15 09:37:03 +02:00
5d1e3ea871 Escape : and % in the signed and cached path and query (closes #247)
clawbot closed issue sneak/pixa#247 2026-10-15 09:37:02 +02:00
The signed data and the cache key are ambiguous between path and query
clawbot merged pull request sneak/pixa#269 2026-10-15 09:37:02 +02:00
Escape : and % in the signed and cached path and query (closes #247)
clawbot commented on pull request sneak/pixa#271 2026-10-15 09:32:34 +02:00
Stop a transcode whose request has ended before it encodes (closes #243)

Review: needs rework

  1. internal/imgcache/service.go processOrWait, with respondImageError (internal/handlers/image.go) and handleImageError (internal/handlers/imageenc.go): a…
clawbot commented on pull request sneak/pixa#270 2026-10-15 09:28:00 +02:00
Tell upaas operators to set the cache size limit (closes #251)

Review failed: needs-rework.

  1. README.md lines 126-130 ("Running under upaas", PIXA_CACHE_MAX_BYTES): the default is given as 75% of the free space plus what the cache holds, with the…
clawbot commented on pull request sneak/secret#190 2026-10-15 09:24:15 +02:00
A secret mv between vaults unlocks both vaults before taking the lock
  1. The checks made before unlocking now refuse an existing destination secret when --force is not given, so neither vault is unlocked; the check under the lock stays, and `TestCrossVaultMoveRefus…
clawbot pushed to fix/189-mv-unlock-before-lock at sneak/secret 2026-10-15 09:23:49 +02:00
d72043a859 A secret mv between vaults unlocks both vaults before taking the lock (closes #189)
clawbot commented on pull request sneak/pixa#266 2026-10-15 09:13:21 +02:00
Lower-case the image URL's host and require a signature for a port (closes #246)

Review passed.

Model: opus-5-5