Block a user
DEBUG accepts only true or false; the code style guide says any non-empty value enables debug mode
Built as decided above in sneak/netwatch#175: DEBUG unset or empty is off, any other value turns debug logging on, and no value stops the start. bin/entrypoint.sh and…
DEBUG turns debug logging on for any non-empty value (closes #159)
Report file writes run one at a time (closes #150)
- Added
TestAppendStartsOneWaitingWrite, which fails ifAppendstarts a write for every report past 10 MiB while one waits, andTestEachSizeThresholdStartsAWrite, which fails if `flushAtThre…
WaitTx and TransactionDetail use the active network instead of the network the transaction was sent on
A refused or failed send on the confirmation screen moves the password field and Sign & Send down
fix: tracked tokens are kept per network, and bundled picks are offered on mainnet only (closes #523)
- A network switch in Settings now makes "Back" render the screen it lands on for the new network, and cuts off the stack the screens that cannot be rendered from saved state, such as Send and…
DECISION: public API surface and determinism defaults for 1.0
DECISION: wire format questions blocking the 1.0 format freeze
DECISION: public API surface and determinism defaults for 1.0
Split per sneak's direction that questions be one issue each (sneak/mfer#81 (comment)): question 11 is settled above, and the one still open, whether to export…
Export the loaded manifest type as Manifest, or an interface in front of it?
DECISION: wire format questions blocking the 1.0 format freeze
None are open. The last one, whether to drop or write mimeType and ctime, is already answered by your rule above (sneak/mfer#81 (comment)): nothing goes in…
Drop mimeType and ctime from the format: 1.0 writes neither
why is CGO being used?
Short answer: almost nothing. In webhooker's history the race detector has caught one data race, and it was in test code, not in webhooker: sneak/webhooker#230 (a…
test: no timer a popup test started fires after cleanupPopup() (closes #578)
fix: the confirmation screen reads its balance on the network it is drawn for (closes #558)
Review failed: needs rework.
The earlier findings are fixed.
- Two comments in
src/popup/views/confirmTx.jsdescribe code this change removed. Lines 45-46 say the insufficient-balance…
.gitignore's shared part is not the standard file from sneak/prompts
Report file writes run one at a time (closes #150)
internal/reportbuf/reportbuf_test.go: nothing teststhresholdWriteWaiting, in either direction. IfAppend(reportbuf.goline 249) started a write for every report past 10 MiB while one…