ConfirmTx. #confirm-errors in src/popup/index.html reserves the height of one empty line, and showSendError() in src/popup/views/confirmTx.js writes sentences of several lines into it when a send is refused or fails, some only after network calls.
What happens
When such a message appears, the box grows and pushes the password field and Sign & Send down. The comment beside the box says it never moves anything on the screen.
What should happen
README, No Layout Shift: error messages and other asynchronous changes "must never move around the existing UI elements". A send failure should appear without moving the password field or Sign & Send.
Severity: minor
Definition of done
A refused or failed send shows its message without moving the password field or Sign & Send.
A browser test records where Sign & Send sits, makes a send fail, and checks it has not moved.
Model: opus-5-5
Seen by the review of https://git.eeqj.de/sneak/AutistMask/pulls/569.
## Where
ConfirmTx. `#confirm-errors` in `src/popup/index.html` reserves the height of one empty line, and `showSendError()` in `src/popup/views/confirmTx.js` writes sentences of several lines into it when a send is refused or fails, some only after network calls.
## What happens
When such a message appears, the box grows and pushes the password field and Sign & Send down. The comment beside the box says it never moves anything on the screen.
## What should happen
README, No Layout Shift: error messages and other asynchronous changes "must _never_ move around the existing UI elements". A send failure should appear without moving the password field or Sign & Send.
Severity: minor
## Definition of done
- [ ] A refused or failed send shows its message without moving the password field or Sign & Send.
- [ ] A browser test records where Sign & Send sits, makes a send fail, and checks it has not moved.
Model: opus-5-5
clawbot
self-assigned this 2026-10-19 03:59:09 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Seen by the review of #569.
Where
ConfirmTx.
#confirm-errorsinsrc/popup/index.htmlreserves the height of one empty line, andshowSendError()insrc/popup/views/confirmTx.jswrites sentences of several lines into it when a send is refused or fails, some only after network calls.What happens
When such a message appears, the box grows and pushes the password field and Sign & Send down. The comment beside the box says it never moves anything on the screen.
What should happen
README, No Layout Shift: error messages and other asynchronous changes "must never move around the existing UI elements". A send failure should appear without moving the password field or Sign & Send.
Severity: minor
Definition of done
Model: opus-5-5