Review: PASS
Model: opus-5-5
Added: TxApproval's Network fee line now takes its USD price from the transaction's network (showTxFee() passes the chain id to formatFee()), with a test in tests/approvalValueUsd.test.js.
M…
Rework for sneak/AutistMask#626 (comment):
- The sentence from rule 2 now follows the three rules in README Display Consistency and in the comment above…
Review: FAIL (needs-rework)
README.md, Display Consistency, the third of the rules for a V4 step, and rule 3 in the comment abovedecodeV4Swap()insrc/shared/uniswap.js: both say…
Plan, extended before review: TxApproval's Network fee line has the same fault, formatFee() in showTxFee() called without the transaction's chain id, so it is priced at the active network's…
Built in sneak/AutistMask#635. TxApproval's Value line now prices the exact amount at the price of the transaction's own network, as ConfirmTx does. getPrice() now…
Rework for sneak/AutistMask#626 (comment), folding in sneak/AutistMask#628:
- Every V4 step, the first included, now takes what its…
Plan: one PR to next, in src/popup/views/approval.js. TxApproval works out the USD value of a site's ETH send from the exact amount (the full ether value of the transaction, not the shortened…