TxApproval, src/popup/views/approval.js. The USD value of a site's ETH send is worked out from the shortened figure (parseFloat(ethValueFormatted) * ethPrice), with the price from getPrice("ETH"), which follows the active network rather than the transaction's.
What happens
The same amount, say 1.23414 ETH, gets a USD value a few cents different on TxApproval than on ConfirmTx, which prices the exact amount on the network the transaction was reviewed for. When the transaction's network differs from the active one, TxApproval prices it at the active network's rate.
What should happen
README, Display Consistency: the same value is never rendered differently on two screens. TxApproval prices the exact amount, at the price of the transaction's own network, as ConfirmTx does.
Severity: minor
Definition of done
TxApproval's USD value for an ETH send comes from the exact amount and the transaction's network's price.
A test with an amount whose shortened and exact USD values differ.
Model: opus-5-5
Seen by the review of https://git.eeqj.de/sneak/AutistMask/pulls/613.
## Where
TxApproval, `src/popup/views/approval.js`. The USD value of a site's ETH send is worked out from the shortened figure (`parseFloat(ethValueFormatted) * ethPrice`), with the price from `getPrice("ETH")`, which follows the active network rather than the transaction's.
## What happens
The same amount, say 1.23414 ETH, gets a USD value a few cents different on TxApproval than on ConfirmTx, which prices the exact amount on the network the transaction was reviewed for. When the transaction's network differs from the active one, TxApproval prices it at the active network's rate.
## What should happen
README, Display Consistency: the same value is never rendered differently on two screens. TxApproval prices the exact amount, at the price of the transaction's own network, as ConfirmTx does.
Severity: minor
## Definition of done
- [ ] TxApproval's USD value for an ETH send comes from the exact amount and the transaction's network's price.
- [ ] A test with an amount whose shortened and exact USD values differ.
Model: opus-5-5
clawbot
self-assigned this 2026-10-19 15:39:54 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Seen by the review of #613.
Where
TxApproval,
src/popup/views/approval.js. The USD value of a site's ETH send is worked out from the shortened figure (parseFloat(ethValueFormatted) * ethPrice), with the price fromgetPrice("ETH"), which follows the active network rather than the transaction's.What happens
The same amount, say 1.23414 ETH, gets a USD value a few cents different on TxApproval than on ConfirmTx, which prices the exact amount on the network the transaction was reviewed for. When the transaction's network differs from the active one, TxApproval prices it at the active network's rate.
What should happen
README, Display Consistency: the same value is never rendered differently on two screens. TxApproval prices the exact amount, at the price of the transaction's own network, as ConfirmTx does.
Severity: minor
Definition of done
Model: opus-5-5