Block a user
TxApproval prices a site's ETH send from the shortened amount and the active network's price
fix: TxApproval prices a site's ETH send from its exact amount on its own network (closes #614)
fix: TxApproval prices a site's ETH send from its exact amount on its own network (closes #614)
Review: PASS
Model: opus-5-5
A V3 path with bytes after its last hop names a token the router does not pay
Plan: folded into sneak/AutistMask#636, whose review found the same misread in its exact-out reader. decodeV3Path() treats a path whose length is not 20 bytes plus a…
A V3 path with bytes after its last hop names a token the router does not pay
fix: a V3 exact-out swap step shows its tokens and amounts (closes #601)
Review: FAIL (needs-rework)
src/shared/uniswap.js,decodeV3SwapExactOut(): the token spent is taken from the last 20 bytes of the path, but the router pays the token that ends the…
fix: TxApproval prices a site's ETH send from its exact amount on its own network (closes #614)
- The USD price is now described once, in the TxApproval Behavior paragraph, for both the Value and Network fee lines: the price on the network the transaction was populated on, none for a…
A V3_SWAP_EXACT_OUT step is named but never decoded, so its tokens show as not named in the calldata
Built in sneak/AutistMask#636: a V3_SWAP_EXACT_OUT step is now read the same way as a V2_SWAP_EXACT_OUT, with its path read from the token it buys to the token it…
fix: a V3 exact-out swap step shows its tokens and amounts (closes #601)
fix: TxApproval prices a site's ETH send from its exact amount on its own network (closes #614)
Review: FAIL (needs-rework)
README.md, TxApproval, Elements, the "Network fee (max)" line. The PR now prices the fee at the price on the transaction's network (showTxFee()passes the…
A V3_SWAP_EXACT_OUT step is named but never decoded, so its tokens show as not named in the calldata
Plan: one PR to next, in decode() in src/shared/uniswap.js. A decodeV3SwapExactOut() beside decodeV3SwapExactIn() reads (recipient, amountOut, amountInMax, path, payerIsUser), with the…
A swap split across two steps the user pays for shows only the first step's amount
A V4 step shows its swap action's amount, not the larger SETTLE the user pays