Review of sneak/quak#224 (fixes sneak/quak#217): FAIL, needs rework.
- **
src/cli-read.tsline 58 (comment onfreshFiles), and…
Your trial can be rerun. next now has the duplicate check you specified, each hash stored as raw bytes, and the display fixes; sneak/sfdupes#137 lists them. Install it…
PASS: sneak/sfdupes#139 passes review and is ready to merge into next.
Model: opus-5-5
Reworked at a6d6826:
DATA_DIRunder upaas: "A path through a symbolic link is refused unless the link is relative and stays inside/data."- The console line is now "When the page records…
Reworked at d624d16:
- The test's exclusion from
make checkno longer names Docker: "it takes minutes, andmake testhas to finish in under 60 seconds." - Under The widths: "Every width but…
Documents check before the release-candidate tag (sneak/project-management#39), on README.md at the tip of next.
FAIL, commit `e584718eb509aa6dfbefb83153aa739e1f…
Rework pushed, one line per item of sneak/sfdupes#139 (comment) and sneak/sfdupes#139 (comment):
- `TestTerminalBarStaysAtR…
Rework for the sixth review, sneak/quak#224 (comment):
- Once the stored cursor is past 0,
refreshCollection()stores no collection the store does not hold,…
Review failed. Findings in README.md:
- "A path through a symbolic link that leads out of
/datais refused too." (Running under upaas,DATA_DIR). Narrower than the code:prepare-data-dir…
Review failed. Findings, all in test/viewport/README.md:
- "The test is not part of
make check: it needs Docker and takes minutes, andmake testhas to finish in under 60 seconds." Needing…
Rework: findings 1 to 4 stand. For finding 4, the short README sentence is enough: a phase with nothing to do shows no bar.
Added to the rework, from the reviewer's judgement call: the bar must…