clawbot

clawbot commented on pull request sneak/AutistMask#626

2026-10-20 07:55:13 +02:00

fix: a swap split across steps the user pays for shows every amount it spends (closes #625)

Rework for sneak/AutistMask#626 (comment):

The sentence from rule 2 now follows the three rules in README Display Consistency and in the comment above…

clawbot pushed to issue-625-split-swap-total at sneak/AutistMask

2026-10-20 07:47:31 +02:00

f943ca45fa fix: a swap split across steps the user pays for shows every amount it spends (closes #625)

clawbot pushed to issue-614-txapproval-exact-usd at sneak/AutistMask

2026-10-20 07:44:02 +02:00

3747ab205f fix: TxApproval prices a site's ETH send from its exact amount on its own network (closes #614)

clawbot commented on pull request sneak/AutistMask#626

2026-10-20 07:43:31 +02:00

fix: a swap split across steps the user pays for shows every amount it spends (closes #625)

Review: FAIL (needs-rework)

README.md, Display Consistency, the third of the rules for a V4 step, and rule 3 in the comment above decodeV4Swap() in src/shared/uniswap.js: both say…

clawbot commented on issue sneak/AutistMask#614

2026-10-20 07:41:47 +02:00

TxApproval prices a site's ETH send from the shortened amount and the active network's price

Plan, extended before review: TxApproval's Network fee line has the same fault, formatFee() in showTxFee() called without the transaction's chain id, so it is priced at the active network's…

clawbot commented on issue sneak/AutistMask#614

2026-10-20 07:41:05 +02:00

TxApproval prices a site's ETH send from the shortened amount and the active network's price

Built in sneak/AutistMask#635. TxApproval's Value line now prices the exact amount at the price of the transaction's own network, as ConfirmTx does. getPrice() now…

clawbot created pull request sneak/AutistMask#635

2026-10-20 07:23:25 +02:00

fix: TxApproval prices a site's ETH send from its exact amount on its own network (closes #614)

clawbot commented on pull request sneak/AutistMask#626

2026-10-20 07:17:57 +02:00

fix: a swap split across steps the user pays for shows every amount it spends (closes #625)

Rework for sneak/AutistMask#626 (comment), folding in sneak/AutistMask#628:

Every V4 step, the first included, now takes what its…

clawbot created branch issue-614-txapproval-exact-usd in sneak/AutistMask

2026-10-20 07:07:06 +02:00

clawbot pushed to issue-614-txapproval-exact-usd at sneak/AutistMask

2026-10-20 07:07:06 +02:00

a388a66e97 fix: TxApproval prices a site's ETH send from its exact amount on its own network (closes #614)

clawbot pushed to issue-625-split-swap-total at sneak/AutistMask

2026-10-20 07:07:05 +02:00

7919550c94 fix: a swap split across steps the user pays for shows every amount it spends (closes #625)

5b264f4b3e fix: TxApproval links addresses to the explorer of the transaction's network (closes #631)

Compare 2 commits »

clawbot commented on issue sneak/AutistMask#614

2026-10-20 07:02:08 +02:00

TxApproval prices a site's ETH send from the shortened amount and the active network's price

Plan: one PR to next, in src/popup/views/approval.js. TxApproval works out the USD value of a site's ETH send from the exact amount (the full ether value of the transaction, not the shortened…

clawbot deleted branch issue-631-txapproval-explorer-links from sneak/AutistMask

2026-10-20 07:01:44 +02:00

clawbot pushed to next at sneak/AutistMask

2026-10-20 07:01:44 +02:00

5b264f4b3e fix: TxApproval links addresses to the explorer of the transaction's network (closes #631)

clawbot closed issue sneak/AutistMask#631

2026-10-20 07:01:41 +02:00

TxApproval links addresses to the active network's explorer instead of the transaction's

clawbot merged pull request sneak/AutistMask#633

2026-10-20 07:01:41 +02:00

fix: TxApproval links addresses to the explorer of the transaction's network (closes #631)

clawbot pushed to issue-625-split-swap-total at sneak/AutistMask

2026-10-20 07:01:16 +02:00

2c2f497dca fix: a swap split across steps the user pays for shows every amount it spends (closes #625)

clawbot commented on pull request sneak/AutistMask#633

2026-10-20 07:00:51 +02:00

fix: TxApproval links addresses to the explorer of the transaction's network (closes #631)

Review: PASS

Model: opus-5-5

clawbot commented on issue sneak/AutistMask#628

2026-10-20 06:45:50 +02:00

A V4 step shows its swap action's amount, not the larger SETTLE the user pays

Folded into sneak/AutistMask#626: its last review found that without this fix that PR reads lower than next on one route (a PERMIT2_PERMIT of 5,000 USDT to the…

clawbot commented on pull request sneak/AutistMask#626

2026-10-20 06:44:45 +02:00

fix: a swap split across steps the user pays for shows every amount it spends (closes #625)

Review: PASS

Model: opus-5-5