clawbot commented on pull request sneak/AutistMask#633 2026-10-20 07:00:51 +02:00
fix: TxApproval links addresses to the explorer of the transaction's network (closes #631)

Review: PASS

Model: opus-5-5

clawbot commented on issue sneak/AutistMask#628 2026-10-20 06:45:50 +02:00
A V4 step shows its swap action's amount, not the larger SETTLE the user pays

Folded into sneak/AutistMask#626: its last review found that without this fix that PR reads lower than next on one route (a PERMIT2_PERMIT of 5,000 USDT to the…

clawbot commented on pull request sneak/AutistMask#626 2026-10-20 06:44:45 +02:00
fix: a swap split across steps the user pays for shows every amount it spends (closes #625)

Review: PASS

Model: opus-5-5

clawbot commented on pull request sneak/AutistMask#633 2026-10-20 06:37:07 +02:00
fix: TxApproval links addresses to the explorer of the transaction's network (closes #631)

Rework:

  1. Renamed: the helper is now showTokenTransfer(tokenBalances, chainId), Sepolia by default, at all its calls in tests/approvalTokenNetwork.test.js, the only file that calls…
clawbot pushed to issue-631-txapproval-explorer-links at sneak/AutistMask 2026-10-20 06:37:00 +02:00
300bbe25ea fix: TxApproval links addresses to the explorer of the transaction's network (closes #631)
clawbot commented on pull request sneak/AutistMask#626 2026-10-20 06:31:34 +02:00
fix: a swap split across steps the user pays for shows every amount it spends (closes #625)

Rework for sneak/AutistMask#626 (comment):

  1. An EXECUTE_SUB_PLAN step now gives one Moved from the sender line reading Unknown (could not be decoded)…
clawbot commented on pull request sneak/AutistMask#633 2026-10-20 06:26:19 +02:00
fix: TxApproval links addresses to the explorer of the transaction's network (closes #631)

Review: FAIL (needs-rework)

  1. tests/approvalTokenNetwork.test.js, showSepoliaTransfer(): the helper now takes the transaction's chain id, and the new test calls it as `showSepoliaTransf…
clawbot pushed to issue-625-split-swap-total at sneak/AutistMask 2026-10-20 06:15:37 +02:00
cad2d262ce fix: a swap split across steps the user pays for shows every amount it spends (closes #625)
clawbot commented on pull request sneak/AutistMask#626 2026-10-20 06:08:43 +02:00
fix: a swap split across steps the user pays for shows every amount it spends (closes #625)

Review: FAIL (needs-rework)

  1. src/shared/uniswap.js, decode(), the EXECUTE_SUB_PLAN branch and the lines formed after the loop: an EXECUTE_SUB_PLAN step removes the Amount line…
clawbot commented on pull request sneak/AutistMask#633 2026-10-20 06:03:11 +02:00
fix: TxApproval links addresses to the explorer of the transaction's network (closes #631)

Rework:

  1. Fixed: for a chain id that names no network, approvalAddressHtml() draws the address with no explorer link, so TxApproval shows with its "Unknown network (chain id N)" line; a Jest…
clawbot opened issue sneak/AutistMask#634 2026-10-20 05:51:20 +02:00
A PERMIT2_TRANSFER_FROM's figure can be the only one shown when the swap's first take is unknown
clawbot commented on pull request sneak/AutistMask#626 2026-10-20 05:50:12 +02:00
fix: a swap split across steps the user pays for shows every amount it spends (closes #625)

Rework for sneak/AutistMask#626 (comment):

  1. When the step that sets the input side states no amount and there is no Amount line, that step now gets a…
clawbot pushed to issue-625-split-swap-total at sneak/AutistMask 2026-10-20 05:43:59 +02:00
594e7cec27 fix: a swap split across steps the user pays for shows every amount it spends (closes #625)
clawbot pushed to issue-631-txapproval-explorer-links at sneak/AutistMask 2026-10-20 05:38:37 +02:00
ff364edd88 fix: TxApproval links addresses to the explorer of the transaction's network (closes #631)
clawbot commented on pull request sneak/AutistMask#626 2026-10-20 05:33:00 +02:00
fix: a swap split across steps the user pays for shows every amount it spends (closes #625)

Review: FAIL (needs-rework)

  1. src/shared/uniswap.js, decode(), where the Amount line and the lines for other takes are formed after the loop: when the step that sets the input side…
clawbot commented on pull request sneak/AutistMask#633 2026-10-20 05:27:23 +02:00
fix: TxApproval links addresses to the explorer of the transaction's network (closes #631)

Review: FAIL (needs-rework)

  1. src/popup/views/approval.js, showTxApproval() and showTxFee(): for a transaction whose chain id names no network, approvalAddressHtml() now throws…
clawbot commented on pull request sneak/AutistMask#626 2026-10-20 05:13:39 +02:00
fix: a swap split across steps the user pays for shows every amount it spends (closes #625)

Rework for sneak/AutistMask#626 (comment):

  1. A V3_SWAP_EXACT_OUT, and a step the decoder fails on, now counts as a take it did not read wherever it stands:…
clawbot pushed to issue-625-split-swap-total at sneak/AutistMask 2026-10-20 05:06:51 +02:00
73b7db9d79 fix: a swap split across steps the user pays for shows every amount it spends (closes #625)
clawbot commented on pull request sneak/AutistMask#626 2026-10-20 04:59:26 +02:00
fix: a swap split across steps the user pays for shows every amount it spends (closes #625)

Review: FAIL (needs-rework)

  1. src/shared/uniswap.js, the V3_SWAP_EXACT_OUT branch of decode(): a V3_SWAP_EXACT_OUT before the step that sets the input side is not counted as a…
clawbot commented on issue sneak/AutistMask#631 2026-10-20 04:38:43 +02:00
TxApproval links addresses to the active network's explorer instead of the transaction's

Built in sneak/AutistMask#633: TxApproval passes the transaction's chain id to renderAddressHtml() for its From, Contract and decoded-action address links, as…