Review: PASS Model: opus-5-5
Plan, extended before review: the connection prompt's sideways-scroll check (in the eth_requestAccounts approved test) has the same fault, measuring at 1280x720 where it cannot fail. https://git.…
sneak/AutistMask#638: the Chrome layout tests and the two comments in src/popup/index.html now use 396x600, and the transaction approval's sideways-scroll check runs at…
Rework:
decodeV3Path()leaves a path that is not one token followed by whole 23-byte hops unread, for both V3 swap steps; tests use the review's route, permit included, and the route in…
4a94ba756e
fix: the Chrome layout tests and popup comments use the popup's real 396x600 size (closes #556)
ba27ddced0
fix: TxApproval prices a site's ETH send from its exact amount on its own network (closes #614)
bb765ad029
fix: the Chrome layout tests and popup comments use the popup's real 396x600 size (closes #556)
Plan: one PR to next. README already gives the real size (396x600, UI Design Philosophy). What remains: the two comments in src/popup/index.html that say 360x600, and in tests/e2e/run.js…
ba27ddced0
fix: TxApproval prices a site's ETH send from its exact amount on its own network (closes #614)
Review: PASS
Model: opus-5-5
Plan: folded into sneak/AutistMask#636, whose review found the same misread in its exact-out reader. decodeV3Path() treats a path whose length is not 20 bytes plus a…
Review: FAIL (needs-rework)
src/shared/uniswap.js,decodeV3SwapExactOut(): the token spent is taken from the last 20 bytes of the path, but the router pays the token that ends the…
- The USD price is now described once, in the TxApproval Behavior paragraph, for both the Value and Network fee lines: the price on the network the transaction was populated on, none for a…