Where.src/popup/styles/main.css (line 31) makes the popup body 396px wide. README.md (UI Design Philosophy, "360x600 popup"), two comments in src/popup/index.html (lines 93 and 215) and POPUP_VIEWPORT in tests/e2e/run.js (line 1833, used by the Chrome layout tests) all say 360x600.
What happens. The Chrome layout tests measure the popup at a width it never has, so a screen that overflows at 396 can pass them, and the README describes a size the popup is not. The Chrome suite's "scrolls sideways" check on the transaction approval passes whatever the page does, because it runs in a 1280x720 window.
Should. The README, the comments and the tests state and use the popup's real size.
Severity: minor
Definition of done
README.md, the two comments in src/popup/index.html and POPUP_VIEWPORT give the popup's real size.
The Chrome layout tests pass at that size, and the transaction approval's sideways-scroll check runs at the approval window's real size, so it can fail.
Model: opus-5-5
Found by the worker on https://git.eeqj.de/sneak/AutistMask/issues/518.
**Where.** `src/popup/styles/main.css` (line 31) makes the popup body 396px wide. `README.md` (UI Design Philosophy, "360x600 popup"), two comments in `src/popup/index.html` (lines 93 and 215) and `POPUP_VIEWPORT` in `tests/e2e/run.js` (line 1833, used by the Chrome layout tests) all say 360x600.
**What happens.** The Chrome layout tests measure the popup at a width it never has, so a screen that overflows at 396 can pass them, and the README describes a size the popup is not. The Chrome suite's "scrolls sideways" check on the transaction approval passes whatever the page does, because it runs in a 1280x720 window.
**Should.** The README, the comments and the tests state and use the popup's real size.
Severity: minor
## Definition of done
- [ ] `README.md`, the two comments in `src/popup/index.html` and `POPUP_VIEWPORT` give the popup's real size.
- [ ] The Chrome layout tests pass at that size, and the transaction approval's sideways-scroll check runs at the approval window's real size, so it can fail.
Model: opus-5-5
clawbot
self-assigned this 2026-10-14 14:02:46 +02:00
Plan: one PR to next. README already gives the real size (396x600, UI Design Philosophy). What remains: the two comments in src/popup/index.html that say 360x600, and in tests/e2e/run.jsPOPUP_VIEWPORT and the 360x600 frame further down, which become 396x600, the size body in src/popup/styles/main.css and openApprovalWindow() in src/background/index.js give it. The Chrome layout tests pass at that size, and the transaction approval's sideways-scroll check runs at the approval window's size (396x600), so it fails if the approval scrolls sideways; shown by making it scroll sideways locally (not pushed).
Model: opus-5-5
Plan: one PR to `next`. README already gives the real size (396x600, UI Design Philosophy). What remains: the two comments in `src/popup/index.html` that say 360x600, and in `tests/e2e/run.js` `POPUP_VIEWPORT` and the 360x600 frame further down, which become 396x600, the size `body` in `src/popup/styles/main.css` and `openApprovalWindow()` in `src/background/index.js` give it. The Chrome layout tests pass at that size, and the transaction approval's sideways-scroll check runs at the approval window's size (396x600), so it fails if the approval scrolls sideways; shown by making it scroll sideways locally (not pushed).
Model: opus-5-5
#638: the Chrome layout tests and the two comments in src/popup/index.html now use 396x600, and the transaction approval's sideways-scroll check runs at that size. The Firefox suite had no fixed size and is unchanged.
Model: opus-5-5
https://git.eeqj.de/sneak/AutistMask/pulls/638: the Chrome layout tests and the two comments in `src/popup/index.html` now use 396x600, and the transaction approval's sideways-scroll check runs at that size. The Firefox suite had no fixed size and is unchanged.
Model: opus-5-5
Plan, extended before review: the connection prompt's sideways-scroll check (in the eth_requestAccounts approved test) has the same fault, measuring at 1280x720 where it cannot fail. #638 sets that page to 396x600 too before measuring, shown to fail locally with body widened.
Model: opus-5-5
Plan, extended before review: the connection prompt's sideways-scroll check (in the `eth_requestAccounts` approved test) has the same fault, measuring at 1280x720 where it cannot fail. https://git.eeqj.de/sneak/AutistMask/pulls/638 sets that page to 396x600 too before measuring, shown to fail locally with `body` widened.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Found by the worker on #518.
Where.
src/popup/styles/main.css(line 31) makes the popup body 396px wide.README.md(UI Design Philosophy, "360x600 popup"), two comments insrc/popup/index.html(lines 93 and 215) andPOPUP_VIEWPORTintests/e2e/run.js(line 1833, used by the Chrome layout tests) all say 360x600.What happens. The Chrome layout tests measure the popup at a width it never has, so a screen that overflows at 396 can pass them, and the README describes a size the popup is not. The Chrome suite's "scrolls sideways" check on the transaction approval passes whatever the page does, because it runs in a 1280x720 window.
Should. The README, the comments and the tests state and use the popup's real size.
Severity: minor
Definition of done
README.md, the two comments insrc/popup/index.htmlandPOPUP_VIEWPORTgive the popup's real size.Model: opus-5-5
Plan: one PR to
next. README already gives the real size (396x600, UI Design Philosophy). What remains: the two comments insrc/popup/index.htmlthat say 360x600, and intests/e2e/run.jsPOPUP_VIEWPORTand the 360x600 frame further down, which become 396x600, the sizebodyinsrc/popup/styles/main.cssandopenApprovalWindow()insrc/background/index.jsgive it. The Chrome layout tests pass at that size, and the transaction approval's sideways-scroll check runs at the approval window's size (396x600), so it fails if the approval scrolls sideways; shown by making it scroll sideways locally (not pushed).Model: opus-5-5
#638: the Chrome layout tests and the two comments in
src/popup/index.htmlnow use 396x600, and the transaction approval's sideways-scroll check runs at that size. The Firefox suite had no fixed size and is unchanged.Model: opus-5-5
Plan, extended before review: the connection prompt's sideways-scroll check (in the
eth_requestAccountsapproved test) has the same fault, measuring at 1280x720 where it cannot fail. #638 sets that page to 396x600 too before measuring, shown to fail locally withbodywidened.Model: opus-5-5