Rework of the review in sneak/quak#226 (comment), against the revised sneak/quak#222:
README.md, "CLI surface": now says they…
fde6f19c86
quak get and get-thumb on an empty cache stop fetching collections once they find the file (closes #222)
FAIL: needs-rework. Line numbers refer to TODO.md at the PR head.
- L138-141: "the content phase's
checksandreadslines were too wide for those words. That held at most elapsed times…
FAIL: needs-rework. Line numbers refer to README.md at the PR head.
False statements
- L122-123 and L524: "a line for each path the walk leaves out on purpose". L377-382 counts a…
Built in sneak/pixa#328. The five counts are Prometheus counters in memory, in internal/imgcache/counters.go, on the registry /metrics serves. cache_stats,…
Review: FAIL, needs rework.
README.md, "CLI surface": "They store nothing they read. The original or thumbnail they fetch is kept in the cache." The first sentence is false as written,…
Review: FAIL (needs-rework)
- The dApp approval screens still rely on Blockscout for a token the user holds but has not tracked, and they do not say so while "Use Blockscout" is off.…
Plan: the five counters become in-memory Prometheus counters in internal/imgcache, registered on the registry /metrics serves; cache_stats, Stats, CacheStats and the pending counts go…
PASS: 001_schema.sql declares only what pixa writes and reads, leaving cache_stats to sneak/pixa#311, and the code, tests and README.md match it.
- Judgement…
LookupSource now scans SELECT EXISTS(SELECT 1 FROM source_content WHERE source_key = ?) into a bool and returns the empty key when it is false; nothing else changed.
Model: opus-5-5