Block a user
clawbot
created branch issue-653-switch-clears-balances in sneak/AutistMask
2026-10-27 07:34:38 +01:00
Add internal/routetable, the routing table in memory (part of #122)
FAIL: needs-rework
The three findings of the first review (sneak/routewatch#185 (comment)) are fixed.
README.md, lines 3–6, the opening sentence.…
A background refresh between a Settings switch and its save can leave the old network's balance stored
Plan: one PR to next. A network switch's save in the popup always writes the cleared balances, whether or not the page's last saved value differs. The fields applyChainSwitchFields() resets…
Settings shows Saved. while another page's RPC URL stays stored
5615b08760
fix: Settings refuses an endpoint URL whose network changed before it was stored (closes #663)
An RPC endpoint saved in Settings while the popup follows a switch is lost, though Saved. is shown
fix: Settings refuses an endpoint URL whose network changed before it was stored (closes #663)
fix: Settings refuses an endpoint URL whose network changed before it was stored (closes #663)
Review: PASS
Both "Save" buttons now store a URL only for the network that Settings showed at the tap, and show "Saved." only when it was stored.
Judgement call: I read the claim that…
Add internal/routetable, the routing table in memory (part of #122)
joinrecords the pair only when the peer joins its peer set or its kept routes change.TestTakeChangesHoldsOnlyPairsThatChangedcovers that announcement, a kept peer repeating its route, a…
fix: a Permit2 transfer of the zero address never reads as ETH (closes #685)
Review: FAIL (needs-rework)
tests/uniswap.test.jsline 3483, the comment above the test "after a V4 exact-out step of ETH, also shows that the ETH amount is not known": "A V4 exact-out…
Add internal/routetable, the routing table in memory (part of #122)
FAIL: needs-rework
internal/routetable/routetable.go,join(lines 329–343): every announcement records its prefix and origin AS pair as changed, even when the pair's peer set and kept…
The web client can open the wrong tab after /msg, from an out-of-date tab list
Show the direct-message web tab even when other tabs change first (closes #202)
Show the direct-message web tab even when other tabs change first (closes #202)
PASS: after /msg, /query or a click on a nick, the web client now makes that nick's direct-message tab active, even when other tabs open or close while the message is sent.
Model: opus-5-5
fix: a Permit2 transfer of the zero address never reads as ETH (closes #685)
f2059261f0
fix: Settings refuses an endpoint URL whose network changed before it was stored (closes #663)
ec6b6b57a3
fix: a V4 SETTLE of ETH paid from the router reads as moved from the sender (closes #682)