Found by the third review of #684, outside its scope.
Where
Settings, the RPC "Save" in src/popup/views/settings.js.
What happens
Another popup page saves a different RPC URL for the same network. Then the user, on this page, presses "Save" on the URL this page loaded. Settings shows "Saved." but the other page's URL stays stored. Read from the code on next; not run in a browser.
What should happen
"Saved." is shown only when the URL on screen is the one stored. The save either stores the URL on screen or says it did not.
Severity: minor
Definition of done
After another page stores a different URL for the same network, "Save" on this page stores the URL on screen and shows "Saved.", or refuses with a plain sentence.
A test, failing on next.
Model: opus-5-5
Found by the third review of https://git.eeqj.de/sneak/AutistMask/pulls/684, outside its scope.
## Where
Settings, the RPC "Save" in `src/popup/views/settings.js`.
## What happens
Another popup page saves a different RPC URL for the same network. Then the user, on this page, presses "Save" on the URL this page loaded. Settings shows "Saved." but the other page's URL stays stored. Read from the code on `next`; not run in a browser.
## What should happen
"Saved." is shown only when the URL on screen is the one stored. The save either stores the URL on screen or says it did not.
Severity: minor
## Definition of done
- [ ] After another page stores a different URL for the same network, "Save" on this page stores the URL on screen and shows "Saved.", or refuses with a plain sentence.
- [ ] A test, failing on `next`.
Model: opus-5-5
clawbot
self-assigned this 2026-10-27 07:27:27 +01:00
Plan: one PR to next. The RPC "Save" in src/popup/views/settings.js always writes the URL on screen into the stored record inside its read-merge-write, even when it matches this page's last saved value, so another page's different URL never stays stored behind a "Saved." flash. The same applies to the Blockscout URL "Save". A Jest test has another page store a different URL, then saves the page's URL, and finds it stored; it fails on next.
Model: opus-5-5
Plan: one PR to `next`. The RPC "Save" in `src/popup/views/settings.js` always writes the URL on screen into the stored record inside its read-merge-write, even when it matches this page's last saved value, so another page's different URL never stays stored behind a "Saved." flash. The same applies to the Blockscout URL "Save". A Jest test has another page store a different URL, then saves the page's URL, and finds it stored; it fails on `next`.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Found by the third review of #684, outside its scope.
Where
Settings, the RPC "Save" in
src/popup/views/settings.js.What happens
Another popup page saves a different RPC URL for the same network. Then the user, on this page, presses "Save" on the URL this page loaded. Settings shows "Saved." but the other page's URL stays stored. Read from the code on
next; not run in a browser.What should happen
"Saved." is shown only when the URL on screen is the one stored. The save either stores the URL on screen or says it did not.
Severity: minor
Definition of done
next.Model: opus-5-5
Plan: one PR to
next. The RPC "Save" insrc/popup/views/settings.jsalways writes the URL on screen into the stored record inside its read-merge-write, even when it matches this page's last saved value, so another page's different URL never stays stored behind a "Saved." flash. The same applies to the Blockscout URL "Save". A Jest test has another page store a different URL, then saves the page's URL, and finds it stored; it fails onnext.Model: opus-5-5