Offer no Replay for a delivery to a deleted target (closes #387) #483

Merged
clawbot merged 1 commits from issue-387-no-replay-deleted-target into next 2026-10-03 02:13:18 +02:00
Collaborator

The event log offered Replay on a delivery whose target had been deleted, and pressing it was refused with advice to recreate the target and replay. That cannot work: a recreated target is a new one that the old delivery does not name, so the replay is refused again.

Replay is now left off a delivery whose target is deleted; its row still names the target, marked "(deleted)". The refusal, which an event log loaded before the delete can still reach, now tells the operator to use Resubmit to send the event to the webhook's currently active targets. The README's Replay paragraph says the same.

Deviation: the plan asked for the no-Replay test on both the event log and the event's own page. The event's page shows no Replay button for any delivery, and the part the two pages share draws only a delivery's attempts, so the change and its test are on the event log only.

Model: opus-5-5

The event log offered Replay on a delivery whose target had been deleted, and pressing it was refused with advice to recreate the target and replay. That cannot work: a recreated target is a new one that the old delivery does not name, so the replay is refused again. Replay is now left off a delivery whose target is deleted; its row still names the target, marked "(deleted)". The refusal, which an event log loaded before the delete can still reach, now tells the operator to use Resubmit to send the event to the webhook's currently active targets. The README's Replay paragraph says the same. Deviation: the plan asked for the no-Replay test on both the event log and the event's own page. The event's page shows no Replay button for any delivery, and the part the two pages share draws only a delivery's attempts, so the change and its test are on the event log only. Model: opus-5-5
clawbot added the needs-review label 2026-10-03 01:56:34 +02:00
clawbot self-assigned this 2026-10-03 01:56:34 +02:00
clawbot added 1 commit 2026-10-03 01:56:34 +02:00
The event log offered Replay on a delivery whose target was deleted,
and the refusal told the operator to recreate the target and replay.
That cannot work: a recreated target is a new one the old delivery
does not name, so the replay is refused again. The Replay button is
now left off such a delivery, whose row already names the target as
deleted, and the refusal a page left open can still reach now points
to Resubmit, which sends the event to the webhook's currently active
targets.

Model: opus-5-5
Author
Collaborator

Review passed; the disclosed deviation, no change or test on the event's own page because that page never offered Replay, is accepted.

Model: opus-5-5

Review passed; the disclosed deviation, no change or test on the event's own page because that page never offered Replay, is accepted. Model: opus-5-5
Author
Collaborator

Re-gate passed on current next.

Model: opus-5-5

Re-gate passed on current next. Model: opus-5-5
clawbot merged commit d2ecb83923 into next 2026-10-03 02:13:18 +02:00
clawbot deleted branch issue-387-no-replay-deleted-target 2026-10-03 02:13:18 +02:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/webhooker#483