Replay is offered for a deleted target, and its refusal gives advice that cannot work #387

Closed
opened 2026-10-01 22:06:19 +02:00 by clawbot · 2 comments
Collaborator

Owner's request, #377 (chat, 2026-10-01):

audit the whole app for stupid cases of missing functionality or basic things like this (like the stats panel at the top that i requested).

What is wrong: in the event log, a delivery to a deleted target, shown as for example "Debug log (deleted)", still has a Replay button. Pressing it answers "Not replayed: the target this delivery was for has been deleted. Recreate the target, then replay." That advice cannot work. Recreating the target makes a new one, and the old delivery still names the deleted target, so the replay is refused again. The action that sends the event to the new target is Resubmit. (templates/source_logs.html; replayOutcome in internal/handlers/delivery_replay.go)

Definition of done:

  • A delivery whose target is deleted has no Replay button. Its row says that the target was deleted.
  • The refusal message, which an old page left open can still reach, tells the operator to use Resubmit to send the event to the webhook's current targets.
  • Tests: no Replay button on a delivery to a deleted target, and the new message text.

PRIORITY: from the owner's audit request of 1 October (#377), in the tier of #367 to #376.

Model: opus-5-5

Owner's request, https://git.eeqj.de/sneak/webhooker/issues/377 (chat, 2026-10-01): > audit the whole app for stupid cases of missing functionality or basic things like this (like the stats panel at the top that i requested). What is wrong: in the event log, a delivery to a deleted target, shown as for example "Debug log (deleted)", still has a Replay button. Pressing it answers "Not replayed: the target this delivery was for has been deleted. Recreate the target, then replay." That advice cannot work. Recreating the target makes a new one, and the old delivery still names the deleted target, so the replay is refused again. The action that sends the event to the new target is Resubmit. (`templates/source_logs.html`; `replayOutcome` in `internal/handlers/delivery_replay.go`) Definition of done: - A delivery whose target is deleted has no Replay button. Its row says that the target was deleted. - The refusal message, which an old page left open can still reach, tells the operator to use Resubmit to send the event to the webhook's current targets. - Tests: no Replay button on a delivery to a deleted target, and the new message text. PRIORITY: from the owner's audit request of 1 October (https://git.eeqj.de/sneak/webhooker/issues/377), in the tier of https://git.eeqj.de/sneak/webhooker/issues/367 to https://git.eeqj.de/sneak/webhooker/issues/376. Model: opus-5-5
clawbot self-assigned this 2026-10-01 22:06:19 +02:00
Author
Collaborator

Plan.

  • In the event log and on the event's page, a delivery whose target is deleted shows no Replay button; its row says the target was deleted (it already names it, as "Debug log (deleted)").
  • The refusal from replayOutcome in internal/handlers/delivery_replay.go, which a page left open can still reach, tells the operator to use Resubmit to send the event to the webhook's current targets.
  • Tests: no Replay button on a delivery to a deleted target on both pages, and the new message text.

Model: opus-5-5

Plan. - In the event log and on the event's page, a delivery whose target is deleted shows no Replay button; its row says the target was deleted (it already names it, as "Debug log (deleted)"). - The refusal from `replayOutcome` in `internal/handlers/delivery_replay.go`, which a page left open can still reach, tells the operator to use Resubmit to send the event to the webhook's current targets. - Tests: no Replay button on a delivery to a deleted target on both pages, and the new message text. Model: opus-5-5
Author
Collaborator

Done in #483. In the event log, a delivery whose target is deleted no longer has a Replay button, and its row still names the target, marked "(deleted)". The refusal, which a page loaded before the delete can still reach, now tells the operator to use Resubmit to send the event to the webhook's currently active targets.

Deviation: the event's own page never showed a Replay button, so nothing changed there and the no-Replay test is on the event log only.

Model: opus-5-5

Done in https://git.eeqj.de/sneak/webhooker/pulls/483. In the event log, a delivery whose target is deleted no longer has a Replay button, and its row still names the target, marked "(deleted)". The refusal, which a page loaded before the delete can still reach, now tells the operator to use Resubmit to send the event to the webhook's currently active targets. Deviation: the event's own page never showed a Replay button, so nothing changed there and the no-Replay test is on the event log only. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/webhooker#387