Remove an http target's max_queue_size (closes #477) #481

Merged
clawbot merged 1 commits from issue-477-remove-max-queue-size into next 2026-10-03 01:39:13 +02:00
Collaborator

An http target's max_queue_size was stored and shown in the target list as "Max Queue Size", but nothing in delivery ever read it, so an operator who set it got no bound on anything. This removes the field from the target, its line in the target list, its row in the README's target table, and the two view tests' use of it. Nothing replaces it and nothing checks for a leftover value.

An existing database keeps its max_queue_size column: the schema is built by adding columns and never drops one, so the old column simply goes unread and no database needs recreating.

Disclosures:

  • Judgement call: the issue mentions the field on the add and edit forms and their validation, but on next neither form has such a field and nothing validates it, so there was nothing to remove there.
  • Judgement call: the README table's first column keeps its old padding; the repo has no markdown formatter and re-padding every row would be noise.

Issue: #477

Model: opus-5-5

An `http` target's `max_queue_size` was stored and shown in the target list as "Max Queue Size", but nothing in delivery ever read it, so an operator who set it got no bound on anything. This removes the field from the target, its line in the target list, its row in the README's target table, and the two view tests' use of it. Nothing replaces it and nothing checks for a leftover value. An existing database keeps its `max_queue_size` column: the schema is built by adding columns and never drops one, so the old column simply goes unread and no database needs recreating. Disclosures: - Judgement call: the issue mentions the field on the add and edit forms and their validation, but on `next` neither form has such a field and nothing validates it, so there was nothing to remove there. - Judgement call: the README table's first column keeps its old padding; the repo has no markdown formatter and re-padding every row would be noise. Issue: https://git.eeqj.de/sneak/webhooker/issues/477 Model: opus-5-5
clawbot added the needs-review label 2026-10-03 01:24:21 +02:00
clawbot self-assigned this 2026-10-03 01:24:21 +02:00
clawbot added 1 commit 2026-10-03 01:24:21 +02:00
Nothing in delivery ever read it, so setting it bounded nothing. The
field, the "Max Queue Size" line in the target list, its README row and
the tests that set or checked it are gone. An existing database keeps
its old column, which is no longer read.

Model: opus-5-5
Author
Collaborator

Review passed.

Model: opus-5-5

Review passed. Model: opus-5-5
clawbot merged commit 22fa502638 into next 2026-10-03 01:39:13 +02:00
clawbot deleted branch issue-477-remove-max-queue-size 2026-10-03 01:39:13 +02:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/webhooker#481