sneak/webhooker
1
0
Fork 0
Code Issues 4 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: remove double cleanShutdown call (closes #21)

Browse Source 
The serve() method called cleanShutdown() after ctx.Done(), and the fx
OnStop hook also called cleanShutdown(). Remove the call in serve() so
shutdown happens exactly once via the fx lifecycle.
This commit is contained in:
clawbot
2026-03-01 16:35:55 -08:00
parent e2ac30287b
commit 36824046fb
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
internal/server/server.go
View File

@@ -109,7 +109,7 @@ func (s *Server) serve() int {
s.log.Info("signal received", "signal", sig.String()) s.log.Info("signal received", "signal", sig.String())
if s.cancelFunc != nil { if s.cancelFunc != nil {
// cancelling the main context will trigger a clean // cancelling the main context will trigger a clean
// shutdown. // shutdown via the fx OnStop hook.
s.cancelFunc() s.cancelFunc()
} }
}() }()
@@ -117,7 +117,8 @@ func (s *Server) serve() int {
go s.serveUntilShutdown() go s.serveUntilShutdown()
<-s.ctx.Done() <-s.ctx.Done()
s.cleanShutdown() // Shutdown is handled by the fx OnStop hook (cleanShutdown).
// Do not call cleanShutdown() here to avoid a double invocation.
return s.exitCode return s.exitCode
} }