Server calls cleanShutdown() twice causing potential errors #21

Nowe zgłoszenie

clawbot · 2026-03-02T01:28:44+01:00

clawbot skomentował(-a)

2026-03-02 01:28:44 +01:00

Bug

The Server.cleanShutdown() method can be called twice during shutdown:

In serve() when the context is cancelled: <-s.ctx.Done() → s.cleanShutdown()
In the fx lifecycle OnStop hook: s.cleanShutdown()

This results in httpServer.Shutdown() being called twice. While http.Server.Shutdown() is likely idempotent, this is fragile and can produce spurious error logs.

Additionally, there's a potential race condition: if fx sends SIGTERM and the internal signal handler fires simultaneously, both goroutines could call cleanShutdown() concurrently without synchronization (no mutex or sync.Once).

Fix

Wrap cleanShutdown() in a sync.Once to ensure it runs exactly once:

type Server struct {
    ...
    shutdownOnce sync.Once
}

func (s *Server) cleanShutdown() {
    s.shutdownOnce.Do(func() {
        // actual shutdown logic
    })
}

Category

Should-fix.

## Bug The `Server.cleanShutdown()` method can be called twice during shutdown: 1. In `serve()` when the context is cancelled: `<-s.ctx.Done()` → `s.cleanShutdown()` 2. In the fx lifecycle `OnStop` hook: `s.cleanShutdown()` This results in `httpServer.Shutdown()` being called twice. While `http.Server.Shutdown()` is likely idempotent, this is fragile and can produce spurious error logs. Additionally, there's a potential race condition: if fx sends SIGTERM and the internal signal handler fires simultaneously, both goroutines could call `cleanShutdown()` concurrently without synchronization (no mutex or sync.Once). ## Fix Wrap `cleanShutdown()` in a `sync.Once` to ensure it runs exactly once: ```go type Server struct { ... shutdownOnce sync.Once } func (s *Server) cleanShutdown() { s.shutdownOnce.Do(func() { // actual shutdown logic }) } ``` ## Category Should-fix.

clawbot odwołał(-a) się do tego zgłoszenia

2026-03-02 01:31:01 +01:00

1.0/mvp #15

clawbot wspomniał(-a) to zgłoszenie z commita

2026-03-02 01:42:00 +01:00

fix: remove double cleanShutdown call (closes #21)

clawbot odwołał(-a) się do tego zgłoszenia

2026-03-02 01:42:14 +01:00

feat: webhooker 1.0 MVP — entity rename, core engine, delivery, management UI #16

clawbot odwołał(-a) się do tego zgłoszenia

2026-03-02 01:42:33 +01:00

1.0/mvp #15