All checks were successful
Check / check (push) Successful in 4s
Bumps golangci-lint from v2.10.1 to v2.12.2 everywhere it is pinned and installs the canonical `.golangci.yml`, then fixes every finding the new linter surfaces so `make check` is green. ## Version pins - `Dockerfile` lint stage: `golangci/golangci-lint:v2.12.2` (Debian-based), tag plus digest pin - `script/bootstrap`: `GOLANGCI_LINT_VERSION=2.12.2` with updated `linux-amd64`/`linux-arm64` release-archive sha256 pins ## Config `.golangci.yml` replaced with the canonical config. Material change: the old file declared `version: "2"` but kept settings under the legacy top-level `linters-settings` key, which golangci-lint v2 ignores — so the intended thresholds (`lll` 88, `funlen` 80/50, `cyclop` 15, `dupl` 100) were not being applied. The canonical file moves them under `linters.settings` and drops `issues.exclude-use-default`. ## Lint fixes (216 findings) - `lll` (96): wrapped lines to the 88-column limit - `noctx` (46): `httptest.NewRequestWithContext` with `t.Context()` throughout the tests - `goconst` (24): shared constants for template/JSON keys in `internal/handlers` and repeated test literals - `gosec` (23): app-page redirects now go through a `redirectToApp` helper that path-escapes the app ID (G710 open redirect); `http.ServeFile` of the internally derived deployment log path annotated like the adjacent `os.Stat` (G703) - `dupl` (22): extracted a generic `findAllByAppID` in `internal/models`, a `deleteAppResource` helper in `internal/handlers`, a shared `parsePush` in `internal/service/webhook`, and table-driven/helper-based dedup in tests - `nolintlint` (5): removed `//nolint:funlen` directives made obsolete by the new limits (plus one more that became obsolete after refactoring) - `nilerr` (3, surfaced during fixing): resource-delete lookups now propagate the find error to the caller No behavior changes intended; all tests pass and `make check` is green. Note: golangci-lint v2.12 warns that `gomodguard` is deprecated in favor of `gomodguard_v2` — a future canonical-config update should address this centrally. Co-authored-by: sneak <sneak@sneak.berlin> Reviewed-on: #187 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>
85 lines
1.7 KiB
Go
85 lines
1.7 KiB
Go
package handlers_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"sneak.berlin/go/upaas/internal/handlers"
|
|
)
|
|
|
|
func TestSanitizeLogs(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
name string
|
|
input string
|
|
expected string
|
|
}{
|
|
{
|
|
name: "plain text unchanged",
|
|
input: "hello world\n",
|
|
expected: "hello world\n",
|
|
},
|
|
{
|
|
name: "strips ANSI color codes",
|
|
input: "\x1b[31mERROR\x1b[0m: something failed\n",
|
|
expected: "ERROR: something failed\n",
|
|
},
|
|
{
|
|
name: "strips OSC sequences",
|
|
input: "\x1b]0;window title\x07normal text\n",
|
|
expected: "normal text\n",
|
|
},
|
|
{
|
|
name: "strips null bytes",
|
|
input: "hello\x00world\n",
|
|
expected: "helloworld\n",
|
|
},
|
|
{
|
|
name: "strips bell characters",
|
|
input: "alert\x07here\n",
|
|
expected: "alerthere\n",
|
|
},
|
|
{
|
|
name: "preserves tabs",
|
|
input: "field1\tfield2\tfield3\n",
|
|
expected: "field1\tfield2\tfield3\n",
|
|
},
|
|
{
|
|
name: "preserves carriage returns",
|
|
input: "line1\r\nline2\r\n",
|
|
expected: "line1\r\nline2\r\n",
|
|
},
|
|
{
|
|
name: "strips mixed escape sequences",
|
|
input: "\x1b[32m2024-01-01\x1b[0m \x1b[1mINFO\x1b[0m starting\x00\n",
|
|
expected: "2024-01-01 INFO starting\n",
|
|
},
|
|
{
|
|
name: "empty string",
|
|
input: "",
|
|
expected: "",
|
|
},
|
|
{
|
|
name: "only control characters",
|
|
input: "\x00\x01\x02\x03",
|
|
expected: "",
|
|
},
|
|
{
|
|
name: "cursor movement sequences stripped",
|
|
input: "\x1b[2J\x1b[H\x1b[3Atext\n",
|
|
expected: "text\n",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
got := handlers.SanitizeLogs(tt.input)
|
|
if got != tt.expected {
|
|
t.Errorf("SanitizeLogs(%q) = %q, want %q", tt.input, got, tt.expected)
|
|
}
|
|
})
|
|
}
|
|
}
|