clawbot
563156ab76
Check / check (pull_request) Skipped
Table cells never wrap, so a long repository URL made the table wider than its card, which hides what does not fit and so cut off the Actions column and the Deploy buttons. The repository URL now wraps within its column, and the card scrolls sideways when the table still does not fit. A handler test checks both. Every class used was already in the committed static/css/tailwind.css. Model: opus-5-5
55 lines
1.6 KiB
Go
55 lines
1.6 KiB
Go
package handlers_test
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"sneak.berlin/go/upaas/internal/service/app"
|
|
)
|
|
|
|
// TestDashboardTableFitsCard checks that the card around the app table
|
|
// scrolls sideways instead of hiding what does not fit, and that a long
|
|
// repository URL wraps instead of pushing the action buttons out.
|
|
func TestDashboardTableFitsCard(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
testCtx := setupTestHandlers(t)
|
|
|
|
repoURL := "https://git.example.com/user/" +
|
|
"a-repository-name-long-enough-to-push-the-action-buttons-out.git"
|
|
|
|
_, err := testCtx.appSvc.CreateApp(t.Context(), app.CreateAppInput{
|
|
Name: "long-url-app",
|
|
RepoURL: repoURL,
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
request := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/", nil)
|
|
recorder := httptest.NewRecorder()
|
|
|
|
testCtx.handlers.HandleDashboard().ServeHTTP(recorder, request)
|
|
|
|
require.Equal(t, http.StatusOK, recorder.Code)
|
|
|
|
body := recorder.Body.String()
|
|
|
|
beforeTable, _, found := strings.Cut(body, `<table class="table">`)
|
|
require.True(t, found, "dashboard has no app table")
|
|
|
|
cardTag := beforeTable[strings.LastIndex(beforeTable, "<div"):]
|
|
assert.Contains(t, cardTag, "overflow-x-auto")
|
|
assert.NotContains(t, cardTag, "overflow-hidden")
|
|
|
|
beforeURL, _, found := strings.Cut(body, ">"+repoURL+"</td>")
|
|
require.True(t, found, "dashboard has no repository cell")
|
|
|
|
cellTag := beforeURL[strings.LastIndex(beforeURL, "<td"):]
|
|
assert.Contains(t, cellTag, "whitespace-normal")
|
|
assert.Contains(t, cellTag, "break-all")
|
|
}
|