sneak/upaas
1
0
Fork 0
Code Issues 21 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

test: add deployment rollback tests (closes #71) #78

Open
clawbot wants to merge 1 commits from feature/deployment-rollback-tests into main
pull from: feature/deployment-rollback-tests
merge into: sneak:main
Conversation 1 Commits 1 Files Changed 5 +130 -56
clawbot commented 2026-02-16 09:28:00 +01:00
Collaborator
Copy Link

Add unit tests for the Rollback method error conditions:

  • ErrNoPreviousImage when no previous image exists
  • ErrNoPreviousImage when previous image is empty string
  • ErrDeploymentInProgress when app deployment lock is held
  • ErrDeploymentInProgress when app lock is already acquired

The rollback feature itself was already implemented on main. This PR adds the missing test coverage.

Test results

All tests pass (make check passes):

  • go test ./... — all PASS
  • golangci-lint — no issues
  • gofmt — clean

Closes #71

Add unit tests for the Rollback method error conditions: - `ErrNoPreviousImage` when no previous image exists - `ErrNoPreviousImage` when previous image is empty string - `ErrDeploymentInProgress` when app deployment lock is held - `ErrDeploymentInProgress` when app lock is already acquired The rollback feature itself was already implemented on main. This PR adds the missing test coverage. ## Test results All tests pass (`make check` passes): - `go test ./...` — all PASS - `golangci-lint` — no issues - `gofmt` — clean Closes #71
sneak was assigned by clawbot 2026-02-16 09:28:00 +01:00
clawbot added 1 commit 2026-02-16 09:28:01 +01:00 
Add tests for Rollback method error paths:
- No previous image available
- Empty previous image string
- App deployment lock held
- App lock already acquired

Relates to #71
sneak commented 2026-02-16 09:52:22 +01:00
Owner
Copy Link

fix merge conflict pls

fix merge conflict pls
This pull request has changes conflicting with the target branch.
  • internal/server/routes.go
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/deployment-rollback-tests:feature/deployment-rollback-tests
git checkout feature/deployment-rollback-tests
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
notplanned

   
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
notplanned
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
sneak
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sneak/upaas#78
No description provided.
Delete Branch "feature/deployment-rollback-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?