sneak/upaas
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 1 Wiki Activity

test: add deployment rollback tests (closes #71) #78

Closed
clawbot wants to merge 1 commits from feature/deployment-rollback-tests into main
pull from: feature/deployment-rollback-tests
merge into: sneak:main
Conversation 1 Commits 1 Files Changed 5 +130 -56
clawbot commented 2026-02-16 09:28:00 +01:00
Collaborator
Copy Link

Add unit tests for the Rollback method error conditions:

  • ErrNoPreviousImage when no previous image exists
  • ErrNoPreviousImage when previous image is empty string
  • ErrDeploymentInProgress when app deployment lock is held
  • ErrDeploymentInProgress when app lock is already acquired

The rollback feature itself was already implemented on main. This PR adds the missing test coverage.

Test results

All tests pass (make check passes):

  • go test ./... — all PASS
  • golangci-lint — no issues
  • gofmt — clean

Closes #71

Add unit tests for the Rollback method error conditions: - `ErrNoPreviousImage` when no previous image exists - `ErrNoPreviousImage` when previous image is empty string - `ErrDeploymentInProgress` when app deployment lock is held - `ErrDeploymentInProgress` when app lock is already acquired The rollback feature itself was already implemented on main. This PR adds the missing test coverage. ## Test results All tests pass (`make check` passes): - `go test ./...` — all PASS - `golangci-lint` — no issues - `gofmt` — clean Closes #71
sneak was assigned by clawbot 2026-02-16 09:28:00 +01:00
clawbot added 1 commit 2026-02-16 09:28:01 +01:00
test: add rollback error condition tests 3c1525d59e 
Add tests for Rollback method error paths:
- No previous image available
- Empty previous image string
- App deployment lock held
- App lock already acquired

Relates to #71
sneak commented 2026-02-16 09:52:22 +01:00
Owner
Copy Link

fix merge conflict pls

fix merge conflict pls
clawbot closed this pull request 2026-02-19 22:40:01 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bot
Agent's turn to work
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
 notplanned
question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees sneak
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/upaas#78
Delete Branch "feature/deployment-rollback-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?