Implements #246. All page changes are in templates/app_detail.html:
Width: the app page's content column goes from a maximum of 56rem (896px, max-w-4xl) to 84rem (1344px). The committed static/css/tailwind.css has no class for 84rem and the repo has no CSS build step, so it is set inline (style="max-width: 84rem;"), the way the log boxes set their height. mx-auto and px-4 stay, so at phone width the column still fills the screen. The site header and other pages are unchanged.
Log heights: the container log and build log boxes go from max-height: 400px to 800px.
Order: "Container Logs" now sits directly above "Deploy Key", and "Last Deployment Build Logs" between "Webhook URL" and "Environment Variables". Both sections moved whole, their Alpine bindings unchanged. Nothing else moved.
The new internal/handlers/app_page_layout_test.go renders the app page and checks the width, the order of all sections and both log heights.
Not visible in the diff: the page fetches a log only while its box is on screen (_isElementVisible in static/js/app-detail.js). With both logs now near the top, they are on screen at page load more often, so they are fetched more often than before.
Partially verified: the browser check (headless Chrome at 1920 and 390 pixels wide, local upaas with a throwaway data directory) used an app with no deployment, so the log boxes were shown and filled with text from the browser to measure their height.
Model: opus-5-5
Implements https://git.eeqj.de/sneak/upaas/issues/246. All page changes are in `templates/app_detail.html`:
- Width: the app page's content column goes from a maximum of 56rem (896px, `max-w-4xl`) to 84rem (1344px). The committed `static/css/tailwind.css` has no class for 84rem and the repo has no CSS build step, so it is set inline (`style="max-width: 84rem;"`), the way the log boxes set their height. `mx-auto` and `px-4` stay, so at phone width the column still fills the screen. The site header and other pages are unchanged.
- Log heights: the container log and build log boxes go from `max-height: 400px` to `800px`.
- Order: "Container Logs" now sits directly above "Deploy Key", and "Last Deployment Build Logs" between "Webhook URL" and "Environment Variables". Both sections moved whole, their Alpine bindings unchanged. Nothing else moved.
The new `internal/handlers/app_page_layout_test.go` renders the app page and checks the width, the order of all sections and both log heights.
Not visible in the diff: the page fetches a log only while its box is on screen (`_isElementVisible` in `static/js/app-detail.js`). With both logs now near the top, they are on screen at page load more often, so they are fetched more often than before.
Partially verified: the browser check (headless Chrome at 1920 and 390 pixels wide, local upaas with a throwaway data directory) used an app with no deployment, so the log boxes were shown and filled with text from the browser to measure their height.
Model: opus-5-5
The app page's content column is now at most 84rem wide instead of
56rem (max-w-4xl), set inline because the committed Tailwind CSS has no
class for that width. The build log and container log boxes are 800px
tall instead of 400px. The build log section moves to between the
webhook URL and the environment variables, and the container log
section moves to directly above the deploy key; nothing else moves. A
new handler test renders the app page and checks the width, the section
order and both log heights.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Implements #246. All page changes are in
templates/app_detail.html:max-w-4xl) to 84rem (1344px). The committedstatic/css/tailwind.csshas no class for 84rem and the repo has no CSS build step, so it is set inline (style="max-width: 84rem;"), the way the log boxes set their height.mx-autoandpx-4stay, so at phone width the column still fills the screen. The site header and other pages are unchanged.max-height: 400pxto800px.The new
internal/handlers/app_page_layout_test.gorenders the app page and checks the width, the order of all sections and both log heights.Not visible in the diff: the page fetches a log only while its box is on screen (
_isElementVisibleinstatic/js/app-detail.js). With both logs now near the top, they are on screen at page load more often, so they are fetched more often than before.Partially verified: the browser check (headless Chrome at 1920 and 390 pixels wide, local upaas with a throwaway data directory) used an app with no deployment, so the log boxes were shown and filled with text from the browser to measure their height.
Model: opus-5-5
Review passed.
Model: opus-5-5
0c3fb96169toc242863f75