The README Configuration table now has a row for every setting upaas reads from the environment, each with the default and effect the code actually has.
New rows: UPAAS_MAINTENANCE_MODE, UPAAS_SESSION_SECRET, UPAAS_CORS_ORIGINS.
Corrected rows: PORT (UPAAS_PORT is also read and wins), UPAAS_DATA_DIR (deploys need an absolute path unless UPAAS_HOST_DATA_DIR is set), UPAAS_HOST_DATA_DIR (falls back to UPAAS_DATA_DIR, must be absolute when set), UPAAS_DEBUG (also drops the session cookie's Secure flag), UPAAS_SENTRY_DSN (not used), UPAAS_METRICS_USERNAME / UPAAS_METRICS_PASSWORD (/metrics exists only when the username is set).
One sentence under the table covers the standard Docker client variables and says UPAAS_DOCKER_HOST always overrides DOCKER_HOST.
TODO.md gets its Completed Steps entry.
Docs only. The Compose port problem (#230) is left alone.
Deviation: the issue says UPAAS_SESSION_SECRET signs CSRF tokens; the CSRF library uses it to sign the CSRF cookie, so the row says "signs the session and CSRF cookies".
Judgement call: the UPAAS_DATA_DIR default now says the Docker image sets /var/lib/upaas (the Dockerfile does), replacing "local dev only — use absolute path for Docker"; the absolute-path requirement is now in the description.
Judgement call: UPAAS_PORT is described in the PORT row instead of a row of its own, since both set the same value.
Judgement call: the UPAAS_DATA_DIR and UPAAS_DOCKER_HOST descriptions were reworded to say what the code uses them for.
Model: opus-5-5
Fixes https://git.eeqj.de/sneak/upaas/issues/229.
The README Configuration table now has a row for every setting upaas reads from the environment, each with the default and effect the code actually has.
- New rows: `UPAAS_MAINTENANCE_MODE`, `UPAAS_SESSION_SECRET`, `UPAAS_CORS_ORIGINS`.
- Corrected rows: `PORT` (`UPAAS_PORT` is also read and wins), `UPAAS_DATA_DIR` (deploys need an absolute path unless `UPAAS_HOST_DATA_DIR` is set), `UPAAS_HOST_DATA_DIR` (falls back to `UPAAS_DATA_DIR`, must be absolute when set), `UPAAS_DEBUG` (also drops the session cookie's `Secure` flag), `UPAAS_SENTRY_DSN` (not used), `UPAAS_METRICS_USERNAME` / `UPAAS_METRICS_PASSWORD` (`/metrics` exists only when the username is set).
- One sentence under the table covers the standard Docker client variables and says `UPAAS_DOCKER_HOST` always overrides `DOCKER_HOST`.
- `TODO.md` gets its Completed Steps entry.
Docs only. The Compose port problem (https://git.eeqj.de/sneak/upaas/issues/230) is left alone.
Deviation: the issue says `UPAAS_SESSION_SECRET` signs CSRF tokens; the CSRF library uses it to sign the CSRF cookie, so the row says "signs the session and CSRF cookies".
Judgement call: the `UPAAS_DATA_DIR` default now says the Docker image sets `/var/lib/upaas` (the `Dockerfile` does), replacing "local dev only — use absolute path for Docker"; the absolute-path requirement is now in the description.
Judgement call: `UPAAS_PORT` is described in the `PORT` row instead of a row of its own, since both set the same value.
Judgement call: the `UPAAS_DATA_DIR` and `UPAAS_DOCKER_HOST` descriptions were reworded to say what the code uses them for.
Model: opus-5-5
README.md, Configuration table, UPAAS_HOST_DATA_DIR row: "Must be absolute, or upaas refuses to start" reads as applying to the default as well. The default is the value of UPAAS_DATA_DIR (./data unless set), and upaas only checks the path when UPAAS_HOST_DATA_DIR itself is set, so it starts fine with that relative default. Acceptable: "When set, it must be absolute, or upaas refuses to start."
Model: opus-5-5
`README.md`, Configuration table, `UPAAS_HOST_DATA_DIR` row: "Must be absolute, or upaas refuses to start" reads as applying to the default as well. The default is the value of `UPAAS_DATA_DIR` (`./data` unless set), and upaas only checks the path when `UPAAS_HOST_DATA_DIR` itself is set, so it starts fine with that relative default. Acceptable: "When set, it must be absolute, or upaas refuses to start."
Model: opus-5-5
README.md Configuration table, UPAAS_HOST_DATA_DIR row: now reads "When set, it must be absolute, or upaas refuses to start." The same phrase in the commit message and PR body now says "must be absolute when set".
Model: opus-5-5
`README.md` Configuration table, `UPAAS_HOST_DATA_DIR` row: now reads "When set, it must be absolute, or upaas refuses to start." The same phrase in the commit message and PR body now says "must be absolute when set".
Model: opus-5-5
README.md Configuration table, UPAAS_DATA_DIR and UPAAS_HOST_DATA_DIR rows: this change drops the old "use absolute path" note from UPAAS_DATA_DIR and says UPAAS_HOST_DATA_DIR is needed when upaas runs in a container, so the table reads as if the default ./data works when upaas runs directly on the host. It does not: with UPAAS_HOST_DATA_DIR unset, a deploy hands the data directory path to Docker as a bind mount source when cloning the repository, Docker rejects a relative path, and every deploy fails. Acceptable: the UPAAS_DATA_DIR row says deploys need it to be an absolute path unless UPAAS_HOST_DATA_DIR is set.
Model: opus-5-5
`README.md` Configuration table, `UPAAS_DATA_DIR` and `UPAAS_HOST_DATA_DIR` rows: this change drops the old "use absolute path" note from `UPAAS_DATA_DIR` and says `UPAAS_HOST_DATA_DIR` is needed when upaas runs in a container, so the table reads as if the default `./data` works when upaas runs directly on the host. It does not: with `UPAAS_HOST_DATA_DIR` unset, a deploy hands the data directory path to Docker as a bind mount source when cloning the repository, Docker rejects a relative path, and every deploy fails. Acceptable: the `UPAAS_DATA_DIR` row says deploys need it to be an absolute path unless `UPAAS_HOST_DATA_DIR` is set.
Model: opus-5-5
The table left out UPAAS_MAINTENANCE_MODE, UPAAS_SESSION_SECRET and
UPAAS_CORS_ORIGINS, and several rows gave the wrong default or effect.
Each row now matches internal/config/config.go and the code that uses
the value: UPAAS_PORT is also read and wins over PORT, UPAAS_DATA_DIR
must be absolute for deploys unless UPAAS_HOST_DATA_DIR is set,
UPAAS_HOST_DATA_DIR falls back to UPAAS_DATA_DIR and must be absolute
when set, UPAAS_DEBUG also drops the session cookie's Secure flag,
UPAAS_SENTRY_DSN is not used, and /metrics exists only when
UPAAS_METRICS_USERNAME is set. A sentence under the table names the
standard Docker client variables. TODO.md records the step.
Model: opus-5-5
Rework: the UPAAS_DATA_DIR row in the README.md Configuration table now says deploys need it to be an absolute path unless UPAAS_HOST_DATA_DIR is set; the commit message and PR body say the same.
Model: opus-5-5
Rework: the `UPAAS_DATA_DIR` row in the `README.md` Configuration table now says deploys need it to be an absolute path unless `UPAAS_HOST_DATA_DIR` is set; the commit message and PR body say the same.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #229.
The README Configuration table now has a row for every setting upaas reads from the environment, each with the default and effect the code actually has.
UPAAS_MAINTENANCE_MODE,UPAAS_SESSION_SECRET,UPAAS_CORS_ORIGINS.PORT(UPAAS_PORTis also read and wins),UPAAS_DATA_DIR(deploys need an absolute path unlessUPAAS_HOST_DATA_DIRis set),UPAAS_HOST_DATA_DIR(falls back toUPAAS_DATA_DIR, must be absolute when set),UPAAS_DEBUG(also drops the session cookie'sSecureflag),UPAAS_SENTRY_DSN(not used),UPAAS_METRICS_USERNAME/UPAAS_METRICS_PASSWORD(/metricsexists only when the username is set).UPAAS_DOCKER_HOSTalways overridesDOCKER_HOST.TODO.mdgets its Completed Steps entry.Docs only. The Compose port problem (#230) is left alone.
Deviation: the issue says
UPAAS_SESSION_SECRETsigns CSRF tokens; the CSRF library uses it to sign the CSRF cookie, so the row says "signs the session and CSRF cookies".Judgement call: the
UPAAS_DATA_DIRdefault now says the Docker image sets/var/lib/upaas(theDockerfiledoes), replacing "local dev only — use absolute path for Docker"; the absolute-path requirement is now in the description.Judgement call:
UPAAS_PORTis described in thePORTrow instead of a row of its own, since both set the same value.Judgement call: the
UPAAS_DATA_DIRandUPAAS_DOCKER_HOSTdescriptions were reworded to say what the code uses them for.Model: opus-5-5
964be9f81atoeb358e67d2README.md, Configuration table,UPAAS_HOST_DATA_DIRrow: "Must be absolute, or upaas refuses to start" reads as applying to the default as well. The default is the value ofUPAAS_DATA_DIR(./dataunless set), and upaas only checks the path whenUPAAS_HOST_DATA_DIRitself is set, so it starts fine with that relative default. Acceptable: "When set, it must be absolute, or upaas refuses to start."Model: opus-5-5
eb358e67d2todfa88eef2dREADME.mdConfiguration table,UPAAS_HOST_DATA_DIRrow: now reads "When set, it must be absolute, or upaas refuses to start." The same phrase in the commit message and PR body now says "must be absolute when set".Model: opus-5-5
README.mdConfiguration table,UPAAS_DATA_DIRandUPAAS_HOST_DATA_DIRrows: this change drops the old "use absolute path" note fromUPAAS_DATA_DIRand saysUPAAS_HOST_DATA_DIRis needed when upaas runs in a container, so the table reads as if the default./dataworks when upaas runs directly on the host. It does not: withUPAAS_HOST_DATA_DIRunset, a deploy hands the data directory path to Docker as a bind mount source when cloning the repository, Docker rejects a relative path, and every deploy fails. Acceptable: theUPAAS_DATA_DIRrow says deploys need it to be an absolute path unlessUPAAS_HOST_DATA_DIRis set.Model: opus-5-5
dfa88eef2dtof01637d62cRework: the
UPAAS_DATA_DIRrow in theREADME.mdConfiguration table now says deploys need it to be an absolute path unlessUPAAS_HOST_DATA_DIRis set; the commit message and PR body say the same.Model: opus-5-5
Review passed.
Model: opus-5-5