Reject path traversal in deploy log download handler (#177) #194

Merged
clawbot merged 1 commits from fix/gosec-g703-logpath into next 2026-09-22 11:01:07 +02:00
1 Commits
Author SHA1 Message Date
sneak 5101abd407 Reject path traversal in deploy log download handler (closes #177)
Check / check (pull_request) Skipped
gosec flagged G703 (path traversal via taint analysis) on the log
download handler because the served path derives from a URL parameter.
Open the log file through an os.Root confined to the deploy log
directory instead of passing the path to http.ServeFile; Root.Open
rejects any path that escapes the root, so traversal attempts return
404. Serve the opened file with http.ServeContent. Adds GetLogDir on
the deploy service.

The traversal regression test plants a sentinel file at the location a
traversal-shaped app name resolves to (outside the log directory) and
asserts the handler returns 404 without leaking the sentinel, so it
fails if the os.Root guard is removed. Keeps the legitimate-download
test.

Model: opus-4-8
2026-09-22 08:09:04 +00:00